From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Matej Vasilevski <matej.vasilevski@seznam.cz>,
Pavel Pisa <pisa@cmp.felk.cvut.cz>,
Ondrej Ille <ondrej.ille@gmail.com>,
Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: can: ctucanfd: add another clock for HW timestamping
Date: Sun, 18 Sep 2022 10:56:39 +0100 [thread overview]
Message-ID: <d279523c-5c66-dfe4-d4a3-116889498815@linaro.org> (raw)
In-Reply-To: <20220914231249.593643-2-matej.vasilevski@seznam.cz>
On 15/09/2022 00:12, Matej Vasilevski wrote:
> Add second clock phandle to specify the timestamping clock.
>
> Signed-off-by: Matej Vasilevski <matej.vasilevski@seznam.cz>
> ---
> .../bindings/net/can/ctu,ctucanfd.yaml | 19 +++++++++++++++----
> 1 file changed, 15 insertions(+), 4 deletions(-)
>
Thank you for your patch. There is something to discuss/improve.
> diff --git a/Documentation/devicetree/bindings/net/can/ctu,ctucanfd.yaml b/Documentation/devicetree/bindings/net/can/ctu,ctucanfd.yaml
> index 4635cb96fc64..432f0e3ed828 100644
> --- a/Documentation/devicetree/bindings/net/can/ctu,ctucanfd.yaml
> +++ b/Documentation/devicetree/bindings/net/can/ctu,ctucanfd.yaml
> @@ -44,9 +44,19 @@ properties:
>
> clocks:
> description: |
> - phandle of reference clock (100 MHz is appropriate
> - for FPGA implementation on Zynq-7000 system).
> - maxItems: 1
> + Phandle of reference clock (100 MHz is appropriate for FPGA
> + implementation on Zynq-7000 system). Optionally add a phandle to
> + the timestamping clock connected to timestamping counter, if used.
> + minItems: 1
> + items:
> + - description: core clock
> + - description: timestamping clock
> +
> + clock-names:
> + minItems: 1
> + items:
> + - const: core-clk
> + - const: ts-clk
Skip the -clk suffixes, so just "core" and "ts".
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-18 9:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 23:12 [PATCH v3 0/3] can: ctucanfd: hardware rx timestamps reporting Matej Vasilevski
2022-09-14 23:12 ` [PATCH v3 1/3] dt-bindings: can: ctucanfd: add another clock for HW timestamping Matej Vasilevski
2022-09-18 9:56 ` Krzysztof Kozlowski [this message]
2022-09-14 23:12 ` [PATCH v3 2/3] can: ctucanfd: add HW timestamps to RX and error CAN frames Matej Vasilevski
2022-09-14 23:12 ` [PATCH v3 3/3] doc: ctucanfd: RX frames timestamping for platform devices Matej Vasilevski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d279523c-5c66-dfe4-d4a3-116889498815@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=matej.vasilevski@seznam.cz \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=ondrej.ille@gmail.com \
--cc=pabeni@redhat.com \
--cc=pisa@cmp.felk.cvut.cz \
--cc=robh+dt@kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).