netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, linux-hams@vger.kernel.org
Subject: [PATCH v2 2/6] AX.25: Print decoded addresses rather than hex numbers.
Date: Sun, 19 Sep 2021 15:30:26 +0200	[thread overview]
Message-ID: <d3d37a741284abfde960cc54411fda09e639fd47.1632059758.git.ralf@linux-mips.org> (raw)
In-Reply-To: <cover.1632059758.git.ralf@linux-mips.org>

Before this, ip would have printed the AX.25 address configured for an
AX.25 interface's default addresses as:

  link/ax25 98:92:9c:aa:b0:40:02 brd a2:a6:a8:40:40:40:00

which is pretty unreadable.  With this commit ip will decode AX.25
addresses like

  link/ax25 LINUX-1 brd QST-0

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
---
 lib/ll_addr.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/ll_addr.c b/lib/ll_addr.c
index 00b562ae..910e6daf 100644
--- a/lib/ll_addr.c
+++ b/lib/ll_addr.c
@@ -39,6 +39,8 @@ const char *ll_addr_n2a(const unsigned char *addr, int alen, int type,
 
 	if (alen == 16 && (type == ARPHRD_TUNNEL6 || type == ARPHRD_IP6GRE))
 		return inet_ntop(AF_INET6, addr, buf, blen);
+	if (alen == 7 && type == ARPHRD_AX25)
+		return ax25_ntop(AF_AX25, addr, buf, blen);
 
 	snprintf(buf, blen, "%02x", addr[0]);
 	for (i = 1, l = 2; i < alen && l < blen; i++, l += 3)
-- 
2.31.1



  parent reply	other threads:[~2021-09-20 14:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-19 13:55 [PATCH v2 0/6] iproute2: Add basic AX.25, NETROM and ROSE support Ralf Baechle
2021-09-19 13:30 ` [PATCH v2 4/6] NETROM: Print decoded addresses rather than hex numbers Ralf Baechle
2021-09-19 13:30 ` [PATCH v2 6/6] ROSE: " Ralf Baechle
2021-09-19 13:30 ` [PATCH v2 3/6] NETROM: Add netrom_ntop implementation Ralf Baechle
2021-09-19 13:30 ` Ralf Baechle [this message]
2021-09-19 13:30 ` [PATCH v2 1/6] AX.25: Add ax25_ntop implementation Ralf Baechle
2021-09-19 13:30 ` [PATCH v2 5/6] ROSE: Add rose_ntop implementation Ralf Baechle
2021-09-24  2:05 ` [PATCH v2 0/6] iproute2: Add basic AX.25, NETROM and ROSE support David Ahern
2021-09-24 11:38   ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3d37a741284abfde960cc54411fda09e639fd47.1632059758.git.ralf@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=linux-hams@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).