From: Michal Simek <michal.simek@xilinx.com>
To: Robert Hancock <robert.hancock@calian.com>,
<netdev@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <robh+dt@kernel.org>,
<michal.simek@xilinx.com>, <nicolas.ferre@microchip.com>,
<claudiu.beznea@microchip.com>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH net-next 1/3] macb: bindings doc: added generic PHY and reset mappings for ZynqMP
Date: Thu, 13 Jan 2022 08:25:22 +0100 [thread overview]
Message-ID: <d5952271-a90f-4794-0087-9781d2258e17@xilinx.com> (raw)
In-Reply-To: <20220112181113.875567-2-robert.hancock@calian.com>
On 1/12/22 19:11, Robert Hancock wrote:
> Updated macb DT binding documentation to reflect the phy-names, phys,
> resets, reset-names properties which are now used with ZynqMP GEM
> devices, and added a ZynqMP-specific DT example.
>
> Signed-off-by: Robert Hancock <robert.hancock@calian.com>
> ---
> .../devicetree/bindings/net/macb.txt | 33 +++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
> index a1b06fd1962e..e526952145b8 100644
> --- a/Documentation/devicetree/bindings/net/macb.txt
> +++ b/Documentation/devicetree/bindings/net/macb.txt
> @@ -29,6 +29,12 @@ Required properties:
> Optional elements: 'rx_clk' applies to cdns,zynqmp-gem
> Optional elements: 'tsu_clk'
> - clocks: Phandles to input clocks.
> +- phy_names, phys: Required with ZynqMP SoC when in SGMII mode.
> + phy_names should be "sgmii-phy" and phys should
> + reference PS-GTR generic PHY device for this controller
> + instance. See ZynqMP example below.
> +- resets, reset-names: Recommended with ZynqMP, specify reset control for this
> + controller instance with zynqmp-reset driver.
>
> Optional properties:
> - mdio: node containing PHY children. If this node is not present, then PHYs
> @@ -58,3 +64,30 @@ Examples:
> reset-gpios = <&pioE 6 1>;
> };
> };
> +
> + gem1: ethernet@ff0c0000 {
> + compatible = "cdns,zynqmp-gem", "cdns,gem";
> + interrupt-parent = <&gic>;
> + interrupts = <0 59 4>, <0 59 4>;
> + reg = <0x0 0xff0c0000 0x0 0x1000>;
> + clocks = <&zynqmp_clk LPD_LSBUS>, <&zynqmp_clk GEM1_REF>,
> + <&zynqmp_clk GEM1_TX>, <&zynqmp_clk GEM1_RX>,
> + <&zynqmp_clk GEM_TSU>;
> + clock-names = "pclk", "hclk", "tx_clk", "rx_clk", "tsu_clk";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + #stream-id-cells = <1>;
> + iommus = <&smmu 0x875>;
> + power-domains = <&zynqmp_firmware PD_ETH_1>;
> + resets = <&zynqmp_reset ZYNQMP_RESET_GEM1>;
> + reset-names = "gem1_rst";
> + status = "okay";
> + phy-mode = "sgmii";
> + phy-names = "sgmii-phy";
> + phys = <&psgtr 1 PHY_TYPE_SGMII 1 1>;
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + pause;
> + };
> + };
Geert already converted this file to yaml that's why you should target this version.
Thanks,
Michal
next prev parent reply other threads:[~2022-01-13 7:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 18:11 [PATCH net-next 0/3] Cadence MACB/GEM support for ZynqMP SGMII Robert Hancock
2022-01-12 18:11 ` [PATCH net-next 1/3] macb: bindings doc: added generic PHY and reset mappings for ZynqMP Robert Hancock
2022-01-13 7:25 ` Michal Simek [this message]
2022-01-13 16:34 ` Robert Hancock
2022-01-13 17:43 ` Geert Uytterhoeven
2022-01-13 17:49 ` Robert Hancock
2022-01-12 18:11 ` [PATCH net-next 2/3] net: macb: Added ZynqMP-specific initialization Robert Hancock
2022-01-13 7:27 ` Michal Simek
2022-01-13 10:14 ` Harini Katakam
2022-01-13 17:14 ` Robert Hancock
2022-01-13 8:04 ` Claudiu.Beznea
2022-01-13 16:32 ` Robert Hancock
2022-01-12 18:11 ` [PATCH net-next 3/3] arm64: dts: zynqmp: Added GEM reset definitions Robert Hancock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5952271-a90f-4794-0087-9781d2258e17@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=claudiu.beznea@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robert.hancock@calian.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).