Netdev Archive on lore.kernel.org
 help / color / Atom feed
From: Yunsheng Lin <linyunsheng@huawei.com>
To: Li RongQing <lirongqing@baidu.com>, <netdev@vger.kernel.org>,
	<saeedm@mellanox.com>
Subject: Re: [PATCH] page_pool: mark unbound node page as reusable pages
Date: Thu, 5 Dec 2019 08:55:20 +0800
Message-ID: <d7836d35-ba21-69ab-8aba-457b2da6ffa1@huawei.com> (raw)
In-Reply-To: <1575454465-15386-1-git-send-email-lirongqing@baidu.com>

On 2019/12/4 18:14, Li RongQing wrote:
> some drivers uses page pool, but not require to allocate
> page from bound node, so pool.p.nid is NUMA_NO_NODE, and
> this fixed patch will block this kind of driver to
> recycle
> 
> Fixes: d5394610b1ba ("page_pool: Don't recycle non-reusable pages")
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
> Cc: Saeed Mahameed <saeedm@mellanox.com>
> ---
>  net/core/page_pool.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/net/core/page_pool.c b/net/core/page_pool.c
> index a6aefe989043..4054db683178 100644
> --- a/net/core/page_pool.c
> +++ b/net/core/page_pool.c
> @@ -317,7 +317,9 @@ static bool __page_pool_recycle_direct(struct page *page,
>   */
>  static bool pool_page_reusable(struct page_pool *pool, struct page *page)
>  {
> -	return !page_is_pfmemalloc(page) && page_to_nid(page) == pool->p.nid;
> +	return !page_is_pfmemalloc(page) &&
> +		(page_to_nid(page) == pool->p.nid ||
> +		 pool->p.nid == NUMA_NO_NODE);

If I understand it correctly, you are allowing recycling when
pool->p.nid is NUMA_NO_NODE, which does not seems match the commit
log: "this fixed patch will block this kind of driver to recycle".

Maybe you mean "commit d5394610b1ba" by this fixed patch?

Also, maybe it is better to allow recycling if the below condition
is matched:

	pool->p.nid == NUMA_NO_NODE && page_to_nid(page) == numa_mem_id()

>  }
>  
>  void __page_pool_put_page(struct page_pool *pool, struct page *page,
> 


  reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04 10:14 Li RongQing
2019-12-05  0:55 ` Yunsheng Lin [this message]
2019-12-05  1:08   ` 答复: " Li,Rongqing
2019-12-05  1:43     ` Yunsheng Lin
2019-12-05  1:55       ` 答复: " Li,Rongqing
2019-12-05  2:06         ` Yunsheng Lin
2019-12-05  2:17           ` 答复: " Li,Rongqing
2019-12-05  2:30             ` Yunsheng Lin
2019-12-05  2:47               ` 答复: " Li,Rongqing
2019-12-05  3:03                 ` Yunsheng Lin
2019-12-05  3:18                   ` 答复: " Li,Rongqing
2019-12-05  3:33                     ` Yunsheng Lin
2019-12-06  8:05                       ` 答复: " Li,Rongqing
2019-12-05  1:22   ` Li,Rongqing

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7836d35-ba21-69ab-8aba-457b2da6ffa1@huawei.com \
    --to=linyunsheng@huawei.com \
    --cc=lirongqing@baidu.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org
	public-inbox-index netdev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git