From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E791C432C3 for ; Tue, 19 Nov 2019 09:01:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4EC4F2173B for ; Tue, 19 Nov 2019 09:01:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726939AbfKSJBC (ORCPT ); Tue, 19 Nov 2019 04:01:02 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:55901 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725798AbfKSJBC (ORCPT ); Tue, 19 Nov 2019 04:01:02 -0500 Received: from soja.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:13da]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1iWzNa-0002sl-E9; Tue, 19 Nov 2019 10:00:58 +0100 Subject: Re: KMSAN: uninit-value in can_receive To: Oliver Hartkopp , Marc Kleine-Budde , syzbot , davem@davemloft.net, glider@google.com, linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com References: <0000000000005c08d10597a3a05d@google.com> <7934bc2b-597f-0bb3-be2d-32f3b07b4de9@hartkopp.net> <7f5c4546-0c1a-86ae-581e-0203b5fca446@pengutronix.de> <1f7d6ea7-152e-ff18-549c-b196d8b5e3a7@hartkopp.net> From: Oleksij Rempel Message-ID: Date: Tue, 19 Nov 2019 10:00:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <1f7d6ea7-152e-ff18-549c-b196d8b5e3a7@hartkopp.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:13da X-SA-Exim-Mail-From: o.rempel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, On 19.11.19 08:35, Oliver Hartkopp wrote: > > > On 18/11/2019 22.15, Marc Kleine-Budde wrote: >> On 11/18/19 9:49 PM, Oliver Hartkopp wrote: >>> >>> >>> On 18/11/2019 21.29, Marc Kleine-Budde wrote: >>>> On 11/18/19 9:25 PM, Oliver Hartkopp wrote: >>> >>>>>> IMPORTANT: if you fix the bug, please add the following tag to the commit: >>>>>> Reported-by: syzbot+b02ff0707a97e4e79ebb@syzkaller.appspotmail.com >>>>>> >>>>>> ===================================================== >>>>>> BUG: KMSAN: uninit-value in can_receive+0x23c/0x5e0 net/can/af_can.c:649 >>>>>> CPU: 1 PID: 3490 Comm: syz-executor.2 Not tainted 5.4.0-rc5+ #0 >>> >>>>> >>>>> In line 649 of 5.4.0-rc5+ we can find a while() statement: >>>>> >>>>> while (!(can_skb_prv(skb)->skbcnt)) >>>>>     can_skb_prv(skb)->skbcnt = atomic_inc_return(&skbcounter); >>>>> >>>>> In linux/include/linux/can/skb.h we see: >>>>> >>>>> static inline struct can_skb_priv *can_skb_prv(struct sk_buff *skb) >>>>> { >>>>>     return (struct can_skb_priv *)(skb->head); >>>>> } >>>>> >>>>> IMO accessing can_skb_prv(skb)->skbcnt at this point is a valid >>>>> operation which has no uninitialized value. >>>>> >>>>> Can this probably be a false positive of KMSAN? >>>> >>>> The packet is injected via the packet socket into the kernel. Where does >>>> skb->head point to in this case? When the skb is a proper >>>> kernel-generated skb containing a CAN-2.0 or CAN-FD frame skb->head is >>>> maybe properly initialized? >>> >>> The packet is either received via vcan or vxcan which checks via >>> can_dropped_invalid_skb() if we have a valid ETH_P_CAN type skb. >> >> According to the call stack it's injected into the kernel via a packet >> socket and not via v(x)can. > > See ioctl$ifreq https://syzkaller.appspot.com/x/log.txt?x=14563416e00000 > > 23:11:34 executing program 2: > r0 = socket(0x200000000000011, 0x3, 0x0) > ioctl$ifreq_SIOCGIFINDEX_vcan(r0, 0x8933, &(0x7f0000000040)={'vxcan1\x00', 0x0}) > bind$packet(r0, &(0x7f0000000300)={0x11, 0xc, r1}, 0x14) > sendmmsg(r0, &(0x7f0000000d00), 0x400004e, 0x0) > > We only can receive skbs from (v(x))can devices. > No matter if someone wrote to them via PF_CAN or PF_PACKET. > We check for ETH_P_CAN(FD) type and ARPHRD_CAN dev type at rx time. > >>> We additionally might think about introducing a check whether we have a >>> can_skb_reserve() created skbuff. >>> >>> But even if someone forged a skbuff without this reserved space the >>> access to can_skb_prv(skb)->skbcnt would point into some CAN frame >>> content - which is still no access to uninitialized content, right? > > So this question remains still valid whether we have a false positive from KMSAN here. It can be other incornation of this bug: https://github.com/linux-can/linux/issues/1 The echo skd was free, because socket which send this skb was closed before it was received. Kind regards, Oleksij Rempel -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |