From: <Mario.Limonciello@dell.com>
To: <kai.heng.feng@canonical.com>, <davem@davemloft.net>,
<hayeswang@realtek.com>
Cc: <jakub.kicinski@netronome.com>, <pmalani@chromium.org>,
<grundler@chromium.org>, <David.Chen7@Dell.com>,
<linux-usb@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] r8152: Add MAC passthrough support to new device
Date: Tue, 14 Jan 2020 20:33:19 +0000 [thread overview]
Message-ID: <d8af34dbf4994b7b8b0bf48e81084dd0@AUSX13MPC101.AMER.DELL.COM> (raw)
In-Reply-To: <20200114044127.20085-1-kai.heng.feng@canonical.com>
> -----Original Message-----
> From: Kai-Heng Feng <kai.heng.feng@canonical.com>
> Sent: Monday, January 13, 2020 10:41 PM
> To: davem@davemloft.net; hayeswang@realtek.com
> Cc: Kai-Heng Feng; Jakub Kicinski; Prashant Malani; Grant Grundler; Limonciello,
> Mario; Chen7, David; open list:USB NETWORKING DRIVERS; open list:NETWORKING
> DRIVERS; open list
> Subject: [PATCH] r8152: Add MAC passthrough support to new device
>
>
> [EXTERNAL EMAIL]
>
> Device 0xa387 also supports MAC passthrough, therefore add it to the
> whitelst.
Have you confirmed whether this product ID is unique to the products that
support this feature or if it's also re-used in other products?
For Dell's devices there are very specific tests that make sure that this
feature only applies on the products it is supposed to and nothing else
(For example RTL8153-AD checks variant as well as effuse value)
(Example two: RTL8153-BND is a Dell only part).
>
> BugLink: https://bugs.launchpad.net/bugs/1827961/comments/30
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
> drivers/net/usb/r8152.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> index c5ebf35d2488..42dcf1442cc0 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
> @@ -6657,7 +6657,8 @@ static int rtl8152_probe(struct usb_interface *intf,
> }
>
> if (le16_to_cpu(udev->descriptor.idVendor) == VENDOR_ID_LENOVO &&
> - le16_to_cpu(udev->descriptor.idProduct) == 0x3082)
> + (le16_to_cpu(udev->descriptor.idProduct) == 0x3082 ||
> + le16_to_cpu(udev->descriptor.idProduct) == 0xa387))
> set_bit(LENOVO_MACPASSTHRU, &tp->flags);
>
> if (le16_to_cpu(udev->descriptor.bcdDevice) == 0x3011 && udev->serial
> &&
> --
> 2.17.1
next prev parent reply other threads:[~2020-01-14 20:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 4:41 [PATCH] r8152: Add MAC passthrough support to new device Kai-Heng Feng
2020-01-14 7:51 ` Prashant Malani
2020-01-14 8:03 ` Kai-Heng Feng
2020-01-14 8:23 ` Oliver Neukum
2020-01-14 9:22 ` Kai-Heng Feng
2020-01-14 20:33 ` Mario.Limonciello [this message]
2020-01-15 6:40 ` Kai Heng Feng
2020-01-15 7:04 ` Hayes Wang
2020-01-15 6:19 ` Hayes Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8af34dbf4994b7b8b0bf48e81084dd0@AUSX13MPC101.AMER.DELL.COM \
--to=mario.limonciello@dell.com \
--cc=David.Chen7@Dell.com \
--cc=davem@davemloft.net \
--cc=grundler@chromium.org \
--cc=hayeswang@realtek.com \
--cc=jakub.kicinski@netronome.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pmalani@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).