From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73BF2C25B50 for ; Mon, 23 Jan 2023 09:42:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230360AbjAWJm2 (ORCPT ); Mon, 23 Jan 2023 04:42:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231483AbjAWJmZ (ORCPT ); Mon, 23 Jan 2023 04:42:25 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE331CA01 for ; Mon, 23 Jan 2023 01:42:22 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id f25-20020a1c6a19000000b003da221fbf48so8059776wmc.1 for ; Mon, 23 Jan 2023 01:42:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=bb3ehCbsmnDNOeIeuOp9X6FACVdZxwB9flFsEny7tkU=; b=dV+vmkhPJupVDkDKPKw/2uJe9dhCfz2931ZZfmSlTiTucpZhV2Dz+B6f9Fv3oiI5Qg xdALFShfLxjvVlVQ2K1bLQ5/4uPa6Q7gCQlFkO7bDQBoW/r8L1iBLX9dM/ZknvefkDGC 6iJRk6CRvJJo7qipP+9FC4RrGHDwX//qae/qj8wJurKg8c+1OHYsm56cHw4p7MWRyk1K nfquz3KQcfaO9EzCTs/SUKrcWz3tEvEos7SFv6WhgRiugJpJ3DnoGoOyT8+BCgVZIzQS gVFXE4RIK7gcAlT4NdXcPy1iZVBPSkMbc+B1+QYLkW51SQ6p0ODeYa+m2ek55Zj8+RQZ DWEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bb3ehCbsmnDNOeIeuOp9X6FACVdZxwB9flFsEny7tkU=; b=2TB4Vzd5mPJwC8XOHrcoPmD7qKDzr0vjDrVr6cJr09Z3u6pR9I04v3tG+ZFKQjTq6d GPGHvNpPuTy0iR0Kq1wpUBfUtOeOPQFdE3y7F/sU01t+dAe4r2yOG2X/TaxwTaw00Dxc 4hfJaz1y7UZluvJtsQ5tLNcFEc0pJQPq1uWPRJ26f15NfVMmTCITJylwujQ8RWrZeKO2 CdzBRIQMfDo8+gduxv4xcYNp7apAi4ehCsRJFNfmcoGdAg8GcmqZOvlVHbLukC7DFXTs DURinXNZRxsb3dmGMEJaqc5CZmdcCIr4jQ6phkYVnT1u+EcV6NKivZZyK/BKBQ5gVgpn O6Qg== X-Gm-Message-State: AFqh2kpDJwZeZMPntZdNZw0dzrDyQPdUG3djGaEswRHGfImNQ8E8MftL z9s1Bwxjs2XpnarLqxVrEiN3Uw== X-Google-Smtp-Source: AMrXdXsm6TcBoxPPxS02VMNxznfImdfA7EnRpT/eJPmFB8AVCLXvlWQuATnvGBXA13pmaGAeWzaHKQ== X-Received: by 2002:a05:600c:1d12:b0:3db:53f:baea with SMTP id l18-20020a05600c1d1200b003db053fbaeamr23030706wms.6.1674466941329; Mon, 23 Jan 2023 01:42:21 -0800 (PST) Received: from [192.168.7.111] (679773502.box.freepro.com. [212.114.21.58]) by smtp.gmail.com with ESMTPSA id t13-20020a1c770d000000b003db1ca20170sm9963482wmi.37.2023.01.23.01.42.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jan 2023 01:42:20 -0800 (PST) Message-ID: Date: Mon, 23 Jan 2023 10:42:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v2 04/11] dt-bindings: watchdog: convert meson-wdt.txt to dt-schema Content-Language: en-US To: Martin Blumenstingl Cc: Rob Herring , Krzysztof Kozlowski , Kevin Hilman , Jerome Brunet , Srinivas Kandagatla , Wim Van Sebroeck , Guenter Roeck , Mauro Carvalho Chehab , Alessandro Zummo , Alexandre Belloni , Daniel Lezcano , Thomas Gleixner , Vinod Koul , Kishon Vijay Abraham I , Ulf Hansson , Bjorn Helgaas , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Heiner Kallweit , Russell King , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-media@vger.kernel.org, linux-rtc@vger.kernel.org, linux-phy@lists.infradead.org, linux-mmc@vger.kernel.org, linux-pci@vger.kernel.org, netdev@vger.kernel.org, Krzysztof Kozlowski References: <20221117-b4-amlogic-bindings-convert-v2-0-36ad050bb625@linaro.org> <20221117-b4-amlogic-bindings-convert-v2-4-36ad050bb625@linaro.org> Organization: Linaro Developer Services In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 10/01/2023 22:48, Martin Blumenstingl wrote: > Hi Neil, > > On Mon, Jan 9, 2023 at 1:53 PM Neil Armstrong wrote: > [...] >> + compatible: >> + oneOf: >> + - enum: >> + - amlogic,meson6-wdt >> + - amlogic,meson8-wdt > Technically this is not an identical representation of what we had > before which was: > - "amlogic,meson8-wdt" and "amlogic,meson6-wdt" on Meson8 SoCs > > We're not using the "amlogic,meson8-wdt" compatible anywhere at the moment. > In the meson_wdt driver it's defined with the same per-SoC data as > "amlogic,meson6-wdt". > > Long story short: In my opinion there's no need to change what you > have right now. > If you have to re-spin this then maybe you can add a note to the patch > description. > Please add my: > Reviewed-by: Martin Blumenstingl Sorry I was distracted, I'll add a node on the commit message. Thanks, Neil > > > Best regards, > Martin