From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B603EC31E5E for ; Tue, 18 Jun 2019 15:20:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8CA86213F2 for ; Tue, 18 Jun 2019 15:20:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="N/QqaHFR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729349AbfFRPUj (ORCPT ); Tue, 18 Jun 2019 11:20:39 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:9307 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728982AbfFRPUj (ORCPT ); Tue, 18 Jun 2019 11:20:39 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 18 Jun 2019 08:20:38 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 18 Jun 2019 08:20:37 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 18 Jun 2019 08:20:37 -0700 Received: from [10.21.132.148] (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 18 Jun 2019 15:20:35 +0000 Subject: Re: [PATCH net-next 3/3] net: stmmac: Convert to phylink and remove phylib logic From: Jon Hunter To: Jose Abreu , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" CC: Joao Pinto , "David S . Miller" , Giuseppe Cavallaro , Alexandre Torgue , Russell King , Andrew Lunn , Florian Fainelli , Heiner Kallweit , linux-tegra References: <6226d6a0de5929ed07d64b20472c52a86e71383d.1560266175.git.joabreu@synopsys.com> <78EB27739596EE489E55E81C33FEC33A0B9C8D6E@DE02WEMBXB.internal.synopsys.com> <26cfaeff-a310-3b79-5b57-fd9c93bd8929@nvidia.com> <78EB27739596EE489E55E81C33FEC33A0B9C8DD9@DE02WEMBXB.internal.synopsys.com> Message-ID: Date: Tue, 18 Jun 2019 16:20:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL106.nvidia.com (172.18.146.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1560871238; bh=Xijyofd1tXJ+PXeQ+C/T9WMQgWP9CU6Ejmt8xNjtMr0=; h=X-PGP-Universal:Subject:From:To:CC:References:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=N/QqaHFR96yPrxOeMfuioFj6iZP1nRH8/dLIcInDbVZ/gLsX0KJyUBeBUMLEeG6ar F7V2RIIJSBZW6GqVrPf9ERYUJVuBW/YwwmZkGFvtQ/VEuQZSCmBI6nJgNDVle8RfVL +vHb8p4KWfbUCoqSVyXP3BDnOP3sCTnAGwTpXaMUAU6HsHEGfUfa3LKNBrYlvCi+Zc pj3NGAXDPDMyU3RrOBD3TJi2cZhb+9XFUrDdNl+nmj+UYQBVZqUCTIQzruEunkKG4y kE+mXMZvEBKqM6+mKD1KXOa5Y4aSP2OTg+xUP7xTGDQLUPhPHxF137uANoDokX349t QkXSpaVLfprGQ== Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 18/06/2019 11:18, Jon Hunter wrote: > > On 18/06/2019 10:46, Jose Abreu wrote: >> From: Jon Hunter >> >>> I am not certain but I don't believe so. We are using a static IP address >>> and mounting the root file-system via NFS when we see this ... >> >> Can you please add a call to napi_synchronize() before every >> napi_disable() calls, like this: >> >> if (queue < rx_queues_cnt) { >> napi_synchronize(&ch->rx_napi); >> napi_disable(&ch->rx_napi); >> } >> >> if (queue < tx_queues_cnt) { >> napi_synchronize(&ch->tx_napi); >> napi_disable(&ch->tx_napi); >> } >> >> [ I can send you a patch if you prefer ] > > Yes I can try this and for completeness you mean ... > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index 4ca46289a742..d4a12cb64d8e 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -146,10 +146,15 @@ static void stmmac_disable_all_queues(struct stmmac_priv *priv) > for (queue = 0; queue < maxq; queue++) { > struct stmmac_channel *ch = &priv->channel[queue]; > > - if (queue < rx_queues_cnt) > + if (queue < rx_queues_cnt) { > + napi_synchronize(&ch->rx_napi); > napi_disable(&ch->rx_napi); > - if (queue < tx_queues_cnt) > + } > + > + if (queue < tx_queues_cnt) { > + napi_synchronize(&ch->tx_napi); > napi_disable(&ch->tx_napi); > + } > } > } So good news and bad news ... The good news is that the above change does fix the initial crash I am seeing. However, even with this change applied on top of -next, it is still dying somewhere else and so there appears to be a second issue. On a successful boot I see ... [ 6.150419] dwc-eth-dwmac 2490000.ethernet: Cannot get CSR clock [ 6.156441] dwc-eth-dwmac 2490000.ethernet: no reset control found [ 6.175866] dwc-eth-dwmac 2490000.ethernet: User ID: 0x10, Synopsys ID: 0x41 [ 6.182912] dwc-eth-dwmac 2490000.ethernet: DWMAC4/5 [ 6.187961] dwc-eth-dwmac 2490000.ethernet: DMA HW capability register supported [ 6.195351] dwc-eth-dwmac 2490000.ethernet: RX Checksum Offload Engine supported [ 6.202735] dwc-eth-dwmac 2490000.ethernet: TX Checksum insertion supported [ 6.209685] dwc-eth-dwmac 2490000.ethernet: Wake-Up On Lan supported [ 6.216041] dwc-eth-dwmac 2490000.ethernet: TSO supported [ 6.221433] dwc-eth-dwmac 2490000.ethernet: Enable RX Mitigation via HW Watchdog Timer [ 6.229342] dwc-eth-dwmac 2490000.ethernet: device MAC address 9a:9b:49:6f:a5:ee [ 6.236727] dwc-eth-dwmac 2490000.ethernet: TSO feature enabled [ 6.242689] libphy: stmmac: probed On the latest -next with the patch applied I see ... [ 6.043529] dwc-eth-dwmac 2490000.ethernet: Cannot get CSR clock [ 6.049546] dwc-eth-dwmac 2490000.ethernet: no reset control found [ 6.068895] dwc-eth-dwmac 2490000.ethernet: User ID: 0x10, Synopsys ID: 0x41 [ 6.075941] dwc-eth-dwmac 2490000.ethernet: DWMAC4/5 [ 6.080989] dwc-eth-dwmac 2490000.ethernet: DMA HW capability register supported [ 6.088373] dwc-eth-dwmac 2490000.ethernet: RX Checksum Offload Engine supported [ 6.095756] dwc-eth-dwmac 2490000.ethernet: TX Checksum insertion supported [ 6.102708] dwc-eth-dwmac 2490000.ethernet: Wake-Up On Lan supported [ 6.109074] dwc-eth-dwmac 2490000.ethernet: TSO supported [ 6.114465] dwc-eth-dwmac 2490000.ethernet: Enable RX Mitigation via HW Watchdog Timer [ 6.122373] dwc-eth-dwmac 2490000.ethernet: device MAC address ee:3a:9a:b0:7e:34 [ 6.129756] dwc-eth-dwmac 2490000.ethernet: TSO feature enabled And it dies here. No more output is seen. I will try to figure out which commit is causing this issue. Cheers Jon -- nvpublic