From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FE8FC76192 for ; Tue, 16 Jul 2019 21:15:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 52DD52173E for ; Tue, 16 Jul 2019 21:15:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388796AbfGPVPK (ORCPT ); Tue, 16 Jul 2019 17:15:10 -0400 Received: from paleale.coelho.fi ([176.9.41.70]:59204 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728781AbfGPVPJ (ORCPT ); Tue, 16 Jul 2019 17:15:09 -0400 Received: from 91-156-6-193.elisa-laajakaista.fi ([91.156.6.193] helo=redipa) by farmhouse.coelho.fi with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hnUmi-0000Yc-7k; Wed, 17 Jul 2019 00:14:54 +0300 Message-ID: From: Luca Coelho To: Nick Desaulniers , Joe Perches , Kalle Valo Cc: Arnd Bergmann , Nathan Chancellor , Johannes Berg , Emmanuel Grumbach , Intel Linux Wireless , "David S. Miller" , Shahar S Matityahu , Sara Sharon , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, LKML , clang-built-linux Date: Wed, 17 Jul 2019 00:14:49 +0300 In-Reply-To: References: <20190712001708.170259-1-ndesaulniers@google.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH -next] iwlwifi: dbg: work around clang bug by marking debug strings static Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 2019-07-16 at 10:28 -0700, Nick Desaulniers wrote: > On Thu, Jul 11, 2019 at 7:15 PM Joe Perches wrote: > > On Thu, 2019-07-11 at 17:17 -0700, Nick Desaulniers wrote: > > > Commit r353569 in prerelease Clang-9 is producing a linkage failure: > > > > > > ld: drivers/net/wireless/intel/iwlwifi/fw/dbg.o: > > > in function `_iwl_fw_dbg_apply_point': > > > dbg.c:(.text+0x827a): undefined reference to `__compiletime_assert_2387' > > > > > > when the following configs are enabled: > > > - CONFIG_IWLWIFI > > > - CONFIG_IWLMVM > > > - CONFIG_KASAN > > > > > > Work around the issue for now by marking the debug strings as `static`, > > > which they probably should be any ways. > > > > > > Link: https://bugs.llvm.org/show_bug.cgi?id=42580 > > > Link: https://github.com/ClangBuiltLinux/linux/issues/580 > > > Reported-by: Arnd Bergmann > > > Reported-by: Nathan Chancellor > > > Signed-off-by: Nick Desaulniers > > > --- > > > drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c > > > index e411ac98290d..f8c90ea4e9b4 100644 > > > --- a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c > > > +++ b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c > > > @@ -2438,7 +2438,7 @@ static void iwl_fw_dbg_info_apply(struct iwl_fw_runtime *fwrt, > > > { > > > u32 img_name_len = le32_to_cpu(dbg_info->img_name_len); > > > u32 dbg_cfg_name_len = le32_to_cpu(dbg_info->dbg_cfg_name_len); > > > - const char err_str[] = > > > + static const char err_str[] = > > > "WRT: ext=%d. Invalid %s name length %d, expected %d\n"; > > > > Better still would be to use the format string directly > > in both locations instead of trying to deduplicate it > > via storing it into a separate pointer. > > > > Let the compiler/linker consolidate the format. > > It's smaller object code, allows format/argument verification, > > and is simpler for humans to understand. > > Whichever Kalle prefers, I just want my CI green again. We already changed this in a later internal patch, which will reach the mainline (-next) soon. So let's skip this for now. -- Cheers, Luca.