From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0059BC4741F for ; Thu, 5 Nov 2020 14:35:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C19F2078E for ; Thu, 5 Nov 2020 14:35:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B6Zuk3Ff" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730859AbgKEOfc (ORCPT ); Thu, 5 Nov 2020 09:35:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726874AbgKEOfc (ORCPT ); Thu, 5 Nov 2020 09:35:32 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83B50C0613CF for ; Thu, 5 Nov 2020 06:35:30 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id w14so2016525wrs.9 for ; Thu, 05 Nov 2020 06:35:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VdFlC44Jmv4HWHPM5u2hzrenpWay662TCfl0+UoCtbk=; b=B6Zuk3FfSgFvbHnhyyqdfNzuJagusEX70MzpgWeeK02zaQGyuL/UCq7kR1HfiC7zus TL6IzT9nOMDfEQ62Ay+U3q7eW1m5Q+nfFwfjOBmjgWopy0kzCO43JSp4F5Emui+s7Dwd aqyXvO63onyot2Qg6gvkhOdTBxx2stxrclO/vtu1oDvwNOg0QWj/H+ZlHqeugiziXNlP r0a4xDg3Sy5dXm9ayONsB+GV6O8Oekzt0E1Mnxzi2m5cLrKuQHWsilKgJ0kNQYmSyhBL Ec8ow/kJSWyM69YhG77HEXFtavNdz8ryiZOTDBQZVqw/QOjWeDjAaFJ+Jrejn61JZoxC favA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VdFlC44Jmv4HWHPM5u2hzrenpWay662TCfl0+UoCtbk=; b=ohVNUP1rspAiMdeIJM2XUJvwZy47+kwkgGDlGXXVIWmbXZPzEV1pbYAFPqACIUANgG nOdp1SdeKhzHrlYcFkiM76sgZfPcLRrlGe427+TRZ+mKfuIthcmr+E1AiF3CRDAvdpkq FWTzFM4AI0VbD6XCMDu1fShrI2dY3Q4O6mjV1OAHfc91ETVe+aCLUuEO1ofiklJVXyoV smohv772Dm64CGKVDtmSFhLLZfsiaSUfiDPHp5nPB6CZcTIcEhLhBV04Acy5jum+8lGW TxtkGDyVjEzDbu504gsXxs86LFRId1yo9XmIFR4non+w2PZfo9+bstwDKkALM37vQqoC ZPuQ== X-Gm-Message-State: AOAM531UmZ2bKPLd8kvZ84GTUZ8an4wO9fn8hbVbrMbKyQADB7wNHc8p rdcryGJug58n0tmxf0QYDYnvBNznJKqPLQ== X-Google-Smtp-Source: ABdhPJw1MifQ1QW6XyhnXYO56yG3bY8knoIb4vzMiaCzLwZbw8U2HZ/JDrqpKK/DF/cuaztGFs7Kog== X-Received: by 2002:a5d:6287:: with SMTP id k7mr3301402wru.402.1604586929047; Thu, 05 Nov 2020 06:35:29 -0800 (PST) Received: from ?IPv6:2003:ea:8f23:2800:59d0:7417:1e79:f522? (p200300ea8f23280059d074171e79f522.dip0.t-ipconnect.de. [2003:ea:8f23:2800:59d0:7417:1e79:f522]) by smtp.googlemail.com with ESMTPSA id t13sm2994487wru.67.2020.11.05.06.35.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Nov 2020 06:35:28 -0800 (PST) Subject: Re: [PATCH net] r8169: disable hw csum for short packets and chip versions with hw padding bug To: David Laight , Jakub Kicinski , David Miller , Realtek linux nic maintainers Cc: "netdev@vger.kernel.org" References: <1a20cb5755db4916b873d88460ccf19e@AcuMS.aculab.com> From: Heiner Kallweit Message-ID: Date: Thu, 5 Nov 2020 15:35:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <1a20cb5755db4916b873d88460ccf19e@AcuMS.aculab.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 05.11.2020 15:20, David Laight wrote: > From: Heiner Kallweit >> Sent: 05 November 2020 13:58 >> >> RTL8125B has same or similar short packet hw padding bug as RTL8168evl. >> The main workaround has been extended accordingly, however we have to >> disable also hw checksumming for short packets on affected new chip >> versions. Change the code in a way that in case of further affected >> chip versions we have to add them in one place only. > > Why not just disable hw checksumming for short packets on > all devices (that use this driver). > Thanks for the hint. Briefly thought about that too but then decided against it as I don't have performance figures. But if everybody is fine with it, then I'd be happy to simplify short packet handling in the described way (in a v2). > It can't make much difference to the performance. > The lack of conditionals may even make it faster. > > David > > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK > Registration No: 1397386 (Wales) > Heiner