From: Johannes Berg <johannes@sipsolutions.net>
To: anton.ivanov@cambridgegreys.com, netdev@vger.kernel.org
Cc: jasowang@redhat.com, virtualization@lists.linux-foundation.org,
linux-um@lists.infradead.org, mst@redhat.com
Subject: Re: [PATCH] virtio: Work around frames incorrectly marked as gso
Date: Mon, 09 Dec 2019 11:54:46 +0100 [thread overview]
Message-ID: <db33800253f071a1cfbb91f413af59e73faa6775.camel@sipsolutions.net> (raw)
In-Reply-To: <20191209104824.17059-1-anton.ivanov@cambridgegreys.com>
> else if (sinfo->gso_type & SKB_GSO_TCPV6)
> hdr->gso_type = VIRTIO_NET_HDR_GSO_TCPV6;
> - else
> - return -EINVAL;
> + else {
> + if (skb->data_len == 0)
> + hdr->gso_type = VIRTIO_NET_HDR_GSO_NONE;
maybe use "else if" like in the before? yes, it's a different type of
condition, but braces look a bit unnatural here to me at least
johannes
next prev parent reply other threads:[~2019-12-09 10:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 10:48 [PATCH] virtio: Work around frames incorrectly marked as gso anton.ivanov
2019-12-09 10:54 ` Johannes Berg [this message]
2020-02-10 16:55 ` Anton Ivanov
2020-02-11 2:51 ` Jason Wang
2020-02-11 7:42 ` Anton Ivanov
2020-02-11 10:37 ` Michael S. Tsirkin
2020-02-12 10:03 ` Anton Ivanov
2020-02-12 10:19 ` Michael S. Tsirkin
2020-02-12 11:17 ` Anton Ivanov
2020-02-12 17:38 ` Anton Ivanov
2020-02-13 3:31 ` Jason Wang
2020-02-13 11:07 ` Anton Ivanov
2020-02-13 10:00 ` Michael S. Tsirkin
2020-02-13 11:12 ` Anton Ivanov
2020-02-13 13:12 ` Michael S. Tsirkin
2020-02-13 15:44 ` Eric Dumazet
2020-02-13 15:53 ` Michael S. Tsirkin
2020-02-13 16:23 ` Anton Ivanov
2020-02-13 16:37 ` Michael S. Tsirkin
2020-02-20 7:58 ` Michael S. Tsirkin
2020-02-20 19:33 ` Anton Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db33800253f071a1cfbb91f413af59e73faa6775.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=anton.ivanov@cambridgegreys.com \
--cc=jasowang@redhat.com \
--cc=linux-um@lists.infradead.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).