From: Edward Cree <ecree@solarflare.com>
To: John Hurley <john.hurley@netronome.com>, <netdev@vger.kernel.org>
Cc: <davem@davemloft.net>, <fw@strlen.de>, <jhs@mojatatu.com>,
<simon.horman@netronome.com>, <jakub.kicinski@netronome.com>,
<oss-drivers@netronome.com>
Subject: Re: [RFC net-next 1/2] net: sched: refactor reinsert action
Date: Mon, 17 Jun 2019 19:43:53 +0100 [thread overview]
Message-ID: <dbd77b82-5951-8512-bc9d-e47abd400be3@solarflare.com> (raw)
In-Reply-To: <1560522831-23952-2-git-send-email-john.hurley@netronome.com>
On 14/06/2019 15:33, John Hurley wrote:
> Instead of
> returning TC_ACT_REINSERT, change the type to the new TC_ACT_CONSUMED
> which tells the caller that the packet has been stolen by another process
> and that no consume call is required.
Possibly a dumb question, but why does this need a new CONSUMED rather
than, say, taking an additional ref and returning TC_ACT_STOLEN?
Apart from that, the series lgtm.
-Ed
next prev parent reply other threads:[~2019-06-17 18:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 14:33 [RFC net-next 0/2] Track recursive calls in TC act_mirred John Hurley
2019-06-14 14:33 ` [RFC net-next 1/2] net: sched: refactor reinsert action John Hurley
2019-06-17 18:43 ` Edward Cree [this message]
2019-06-17 22:11 ` John Hurley
2019-06-18 18:57 ` Jakub Kicinski
2019-06-14 14:33 ` [RFC net-next 2/2] net: sched: protect against stack overflow in TC act_mirred John Hurley
2019-06-14 14:45 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbd77b82-5951-8512-bc9d-e47abd400be3@solarflare.com \
--to=ecree@solarflare.com \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=jakub.kicinski@netronome.com \
--cc=jhs@mojatatu.com \
--cc=john.hurley@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).