From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 326D2C433E0 for ; Wed, 3 Feb 2021 01:04:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CDA7F64F50 for ; Wed, 3 Feb 2021 01:04:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229966AbhBCBEx (ORCPT ); Tue, 2 Feb 2021 20:04:53 -0500 Received: from mga04.intel.com ([192.55.52.120]:24055 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229729AbhBCBEx (ORCPT ); Tue, 2 Feb 2021 20:04:53 -0500 IronPort-SDR: bG8g0LRlwCjIGh9NHKIMrUTgOqH8i4tKZNPS/8BhZxuZO6p+KsbWV9ZjZtmncwTIyvjxAzIgn8 0ZIsFXhlL7nw== X-IronPort-AV: E=McAfee;i="6000,8403,9883"; a="178402593" X-IronPort-AV: E=Sophos;i="5.79,396,1602572400"; d="scan'208";a="178402593" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 17:04:12 -0800 IronPort-SDR: WlEExi0fnFb3ba3E21yQx0RRrEKP9Pf14bqAFJ2A4f1lpH5k2fDBazBAOzTyLuOA8b8ggHgnR2 bA5U3NC4QTwA== X-IronPort-AV: E=Sophos;i="5.79,396,1602572400"; d="scan'208";a="392043889" Received: from shao2-debian.sh.intel.com (HELO [10.239.13.11]) ([10.239.13.11]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 17:04:11 -0800 Subject: Re: [PATCH] selftests/tls: fix compile errors after adding CHACHA20-POLY1305 To: Jakub Kicinski Cc: Boris Pismenny , Aviad Yehezkel , Vadim Fedorenko , netdev@vger.kernel.org, kernel test robot References: <20210202094500.679761-1-rong.a.chen@intel.com> <20210202135307.6a2306fc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Rong Chen Message-ID: Date: Wed, 3 Feb 2021 09:03:41 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20210202135307.6a2306fc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/3/21 5:53 AM, Jakub Kicinski wrote: > On Tue, 2 Feb 2021 17:45:00 +0800 Rong Chen wrote: >> The kernel test robot reported the following errors: >> >> tls.c: In function ‘tls_setup’: >> tls.c:136:27: error: storage size of ‘tls12’ isn’t known >> union tls_crypto_context tls12; >> ^~~~~ >> tls.c:150:21: error: ‘tls12_crypto_info_chacha20_poly1305’ undeclared (first use in this function) >> tls12_sz = sizeof(tls12_crypto_info_chacha20_poly1305); >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> tls.c:150:21: note: each undeclared identifier is reported only once for each function it appears in >> tls.c:153:21: error: ‘tls12_crypto_info_aes_gcm_128’ undeclared (first use in this function) >> tls12_sz = sizeof(tls12_crypto_info_aes_gcm_128); >> >> Fixes: 4f336e88a870 ("selftests/tls: add CHACHA20-POLY1305 to tls selftests") >> Reported-by: kernel test robot >> Link: https://lore.kernel.org/lkml/20210108064141.GB3437@xsang-OptiPlex-9020/ >> Signed-off-by: Rong Chen > Are you sure you have latest headers installed on your system? > > Try make headers_install or some such, I forgot what the way to appease > selftest was exactly but selftests often don't build on a fresh kernel > clone if system headers are not very recent :S Hi Jakub, These errors still exist when testing the latest linux-next/master branch on our test system, and kernelci noticed the errors too: https://storage.staging.kernelci.org/kernelci/staging-mainline/staging-mainline-20210130.0/x86_64/x86_64_defconfig+kselftest/gcc-8/build.log Best Regards, Rong Chen