From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 987B6C433E1 for ; Tue, 14 Jul 2020 13:25:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A0EC22461 for ; Tue, 14 Jul 2020 13:25:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cumulusnetworks.com header.i=@cumulusnetworks.com header.b="ZCEEJ384" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728652AbgGNNZA (ORCPT ); Tue, 14 Jul 2020 09:25:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728006AbgGNNY7 (ORCPT ); Tue, 14 Jul 2020 09:24:59 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D5A1C061794 for ; Tue, 14 Jul 2020 06:24:59 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id z13so21574001wrw.5 for ; Tue, 14 Jul 2020 06:24:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=Aj4QKKJojEodXlG0rvLUNxVoPZ5Fr2yPYro2NiVUoeE=; b=ZCEEJ384Iu1DGQxnvlhX72M4mccDWl5ldcoVeiCEHr08wVI+D8Q5hSZH2B9pZ6bUcE ue6vH3qGR35NPbHd13201SO7tYLiwSm+t3EwJNAmINb0vvzEh2KSOlIlqNoPF6YXfpW+ /C17pnz3hPkxbrQ96By5VAGCS0+66sxIVXvyM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Aj4QKKJojEodXlG0rvLUNxVoPZ5Fr2yPYro2NiVUoeE=; b=cJZkz+6ow/8SX5PMSsHsaJrROUP00l4JnTF2zHI0Ens/4yI+oDo26JAJ7bBkBKgcMo 0GQIc5EOpZUooR35gWqdS5/aoYn6CgB8hkdUPbVHiKavlWuTYraSPa9nvzPxu/NK1vJi qrIbFtnVHx5azzTqes5KXitSczmmNdYbN8+mA39KtFun0hKnv1LCGyfrGK3/XZxTkZAL /u62sMBZxiZZ8F6MfjudBrEIQ8jV2zxj+86NVZT0cbgm+feVcABRJBCe1VEeKGe8yVm3 5xUihu9uNQSPNsrCQtZfn9yQVjTl/dBSlpJrJyJpXVFIvOwTZc9yMmZFJVdwfxmlXXUa fCjA== X-Gm-Message-State: AOAM531SHKxxIy5mPm+v1QaNgiMZm5QHyu7mRvDYpfgmc6oojBLooqnv lyfBpBcyO7IsS7sfoiOgrLFPBg== X-Google-Smtp-Source: ABdhPJxfYCnUzieYF2XQSYACq4ky+aYgmc2GjwcyD9wVgHGUQeJ272sYluyQFMzuOSGk8Mo5Hxhlvw== X-Received: by 2002:a5d:55ca:: with SMTP id i10mr2854011wrw.225.1594733098176; Tue, 14 Jul 2020 06:24:58 -0700 (PDT) Received: from [192.168.0.109] (84-238-136-197.ip.btc-net.bg. [84.238.136.197]) by smtp.gmail.com with ESMTPSA id t4sm4598552wmf.4.2020.07.14.06.24.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jul 2020 06:24:57 -0700 (PDT) Subject: Re: [PATCH net-next v4 11/12] bridge: mrp: Extend br_mrp_fill_info To: Horatiu Vultur , roopa@cumulusnetworks.com, davem@davemloft.net, kuba@kernel.org, jiri@resnulli.us, ivecera@redhat.com, andrew@lunn.ch, UNGLinuxDriver@microchip.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org References: <20200714073458.1939574-1-horatiu.vultur@microchip.com> <20200714073458.1939574-12-horatiu.vultur@microchip.com> From: Nikolay Aleksandrov Message-ID: Date: Tue, 14 Jul 2020 16:24:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200714073458.1939574-12-horatiu.vultur@microchip.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 14/07/2020 10:34, Horatiu Vultur wrote: > This patch extends the function br_mrp_fill_info to return also the > status for the interconnect ring. > > Signed-off-by: Horatiu Vultur > --- > net/bridge/br_mrp_netlink.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/net/bridge/br_mrp_netlink.c b/net/bridge/br_mrp_netlink.c > index a006e0771e8d3..2a2fdf3500c5b 100644 > --- a/net/bridge/br_mrp_netlink.c > +++ b/net/bridge/br_mrp_netlink.c > @@ -474,6 +474,11 @@ int br_mrp_fill_info(struct sk_buff *skb, struct net_bridge *br) > p->dev->ifindex)) > goto nla_put_failure; > > + p = rcu_dereference(mrp->i_port); > + if (p && nla_put_u32(skb, IFLA_BRIDGE_MRP_INFO_I_IFINDEX, > + p->dev->ifindex)) > + goto nla_put_failure; > + > if (nla_put_u16(skb, IFLA_BRIDGE_MRP_INFO_PRIO, > mrp->prio)) > goto nla_put_failure; > @@ -493,6 +498,19 @@ int br_mrp_fill_info(struct sk_buff *skb, struct net_bridge *br) > mrp->test_monitor)) > goto nla_put_failure; > > + if (nla_put_u32(skb, IFLA_BRIDGE_MRP_INFO_IN_STATE, > + mrp->in_state)) > + goto nla_put_failure; > + if (nla_put_u32(skb, IFLA_BRIDGE_MRP_INFO_IN_ROLE, > + mrp->in_role)) > + goto nla_put_failure; > + if (nla_put_u32(skb, IFLA_BRIDGE_MRP_INFO_IN_TEST_INTERVAL, > + mrp->in_test_interval)) > + goto nla_put_failure; > + if (nla_put_u32(skb, IFLA_BRIDGE_MRP_INFO_IN_TEST_MAX_MISS, > + mrp->in_test_max_miss)) > + goto nla_put_failure; > + > nla_nest_end(skb, tb); > } > nla_nest_end(skb, mrp_tb); > Acked-by: Nikolay Aleksandrov