From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Ahern <dsahern@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, johannes.berg@intel.com,
edumazet@google.com, David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net] netlink: Fix nlmsg_parse as a wrapper for strict message parsing
Date: Tue, 13 Aug 2019 13:31:34 +0200 [thread overview]
Message-ID: <dec209a4-b72a-86c3-d8d5-a080e1249886@gmail.com> (raw)
In-Reply-To: <20190812200707.25587-1-dsahern@kernel.org>
On 8/12/19 10:07 PM, David Ahern wrote:
> From: David Ahern <dsahern@gmail.com>
>
> Eric reported a syzbot warning:
>
>
> The root cause is nlmsg_parse calling __nla_parse which means the
> header struct size is not checked.
>
> nlmsg_parse should be a wrapper around __nlmsg_parse with
> NL_VALIDATE_STRICT for the validate argument very much like
> nlmsg_parse_deprecated is for NL_VALIDATE_LIBERAL.
>
> Fixes: 3de6440354465 ("netlink: re-add parse/validate functions in strict mode")
> Reported-by: Eric Dumazet <edumazet@google.com>
> Reported-by: syzbot <syzkaller@googlegroups.com>
> Signed-off-by: David Ahern <dsahern@gmail.com>
> ---
Reviewed-by: Eric Dumazet <edumazet@google.com>
Thanks !
next prev parent reply other threads:[~2019-08-13 11:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 20:07 [PATCH net] netlink: Fix nlmsg_parse as a wrapper for strict message parsing David Ahern
2019-08-13 11:31 ` Eric Dumazet [this message]
2019-08-14 3:43 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dec209a4-b72a-86c3-d8d5-a080e1249886@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=johannes.berg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).