From: Ferenc Fejes <ferenc.fejes@ericsson.com>
To: Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "Arvid.Brodin@xdin.com" <Arvid.Brodin@xdin.com>,
"m-karicheri2@ti.com" <m-karicheri2@ti.com>,
"vinicius.gomes@intel.com" <vinicius.gomes@intel.com>,
"michael.chan@broadcom.com" <michael.chan@broadcom.com>,
"vishal@chelsio.com" <vishal@chelsio.com>,
"saeedm@mellanox.com" <saeedm@mellanox.com>,
"jiri@mellanox.com" <jiri@mellanox.com>,
"idosch@mellanox.com" <idosch@mellanox.com>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"ivan.khoronzhuk@linaro.org" <ivan.khoronzhuk@linaro.org>,
"andre.guedes@linux.intel.com" <andre.guedes@linux.intel.com>,
"allan.nielsen@microchip.com" <allan.nielsen@microchip.com>,
"joergen.andreasen@microchip.com"
<joergen.andreasen@microchip.com>,
"vladimir.oltean@nxp.com" <vladimir.oltean@nxp.com>,
"jhs@mojatatu.com" <jhs@mojatatu.com>
Subject: Re: [RFC, net-next] net: qos: introduce a frer action to implement 802.1CB
Date: Fri, 6 May 2022 11:55:56 +0000 [thread overview]
Message-ID: <df67ceaa-4240-d084-7ba1-d703f0c38f33@ericsson.com> (raw)
In-Reply-To: <20210928114451.24956-1-xiaoliang.yang_1@nxp.com>
On 2021. 09. 28. 13:44, Xiaoliang Yang wrote:
> This patch introduce a frer action to implement frame replication and
> elimination for reliability, which is defined in IEEE P802.1CB.
HiXiaoliang!
thanks for your efforts to introduce afreraction to implement frame
replication and elimination for reliability, which is defined in IEEE
P802.1CB-2017. I would like to relay a small comment from our team,
regarding to the FRER, not particularly to the code.
Support of RTAG format is very straightforward.
Since 2017, several maintenance items were opened regarding IEEE
P802.1CB-2017 to fix some errors in the standard. Discussions results
will be published soon e.g., in IEEE P802.1CBdb
(https://1.ieee802.org/tsn/802-1cbdb/).
One of the maintenance items impacts the vector recovery algorithm itself.
Details on the problem and the solution are here:
-https://www.802-1.org/items/370
-https://www.ieee802.org/1/files/public/docs2020/maint-varga-257-FRER-recovery-window-0320-v01.pdf
<https://www.ieee802.org/1/files/public/docs2020/maint-varga-257-FRER-recovery-window-0320-v01.pdf>
It is a small but important fix. There is an incorrect reference to the
size of the recovery window, when a received packet is checked to be
out-of-range or not. Without this fix the vector recovery algorithm do
not work properly in some scenarios.
Please consider to update your patch to reflect the maintenance efforts
of IEEE to correct .1CB-2017 related issues.
> There are two modes for frer action: generate and push the tag, recover
> and pop the tag. frer tag has three types: RTAG, HSR, and PRP. This
> patch only supports RTAG now.
>
> User can push the tag on egress port of the talker device, recover and
> pop the tag on ingress port of the listener device. When it's a relay
> system, push the tag on ingress port, or set individual recover on
> ingress port. Set the sequence recover on egress port.
>
> Use action "mirred" to do split function, and use "vlan-modify" to do
> active stream identification function on relay system.
>
All of our research in the topic based on a in-house userspace FRER
implementation but we are looking forward to test your work in the future.
Thanks,
Ferenc
next prev parent reply other threads:[~2022-05-06 11:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 11:44 [RFC, net-next] net: qos: introduce a frer action to implement 802.1CB Xiaoliang Yang
2021-09-28 22:34 ` Vinicius Costa Gomes
2021-09-29 10:25 ` [EXT] " Xiaoliang Yang
2021-10-01 16:17 ` Vladimir Oltean
2021-10-01 17:13 ` Vinicius Costa Gomes
2021-10-01 17:27 ` Vinicius Costa Gomes
2021-10-01 17:55 ` Vladimir Oltean
2021-10-01 18:11 ` Vladimir Oltean
2021-10-01 22:56 ` Vinicius Costa Gomes
2021-10-04 18:52 ` Vinicius Costa Gomes
2022-05-06 11:55 ` Ferenc Fejes [this message]
2022-05-06 12:23 ` Vladimir Oltean
2022-05-06 14:44 ` Ferenc Fejes
2022-05-06 19:31 ` Vladimir Oltean
2022-05-09 11:27 ` István Moldován
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df67ceaa-4240-d084-7ba1-d703f0c38f33@ericsson.com \
--to=ferenc.fejes@ericsson.com \
--cc=Arvid.Brodin@xdin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=allan.nielsen@microchip.com \
--cc=andre.guedes@linux.intel.com \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=ivan.khoronzhuk@linaro.org \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=joergen.andreasen@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=vinicius.gomes@intel.com \
--cc=vishal@chelsio.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiaoliang.yang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).