From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C41C3ECE58E for ; Fri, 11 Oct 2019 06:47:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A8F41214E0 for ; Fri, 11 Oct 2019 06:47:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727399AbfJKGrN (ORCPT ); Fri, 11 Oct 2019 02:47:13 -0400 Received: from s3.sipsolutions.net ([144.76.43.62]:60888 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726481AbfJKGrN (ORCPT ); Fri, 11 Oct 2019 02:47:13 -0400 Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.92.2) (envelope-from ) id 1iIohY-0003Kb-Qd; Fri, 11 Oct 2019 08:47:00 +0200 Message-ID: Subject: Re: [PATCH net-next v7 00/17] ethtool netlink interface, part 1 From: Johannes Berg To: Jakub Kicinski , Michal Kubecek Cc: David Miller , netdev@vger.kernel.org, Jiri Pirko , Andrew Lunn , Florian Fainelli , John Linville , Stephen Hemminger , linux-kernel@vger.kernel.org Date: Fri, 11 Oct 2019 08:46:59 +0200 In-Reply-To: <20191010174839.6e44158b@cakuba.netronome.com> (sfid-20191011_024857_967575_978B3526) References: <20191010174839.6e44158b@cakuba.netronome.com> (sfid-20191011_024857_967575_978B3526) Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 2019-10-10 at 17:48 -0700, Jakub Kicinski wrote: > On Wed, 9 Oct 2019 22:59:00 +0200 (CEST), Michal Kubecek wrote: > > This is first part of netlink based alternative userspace interface for > > ethtool. It aims to address some long known issues with the ioctl > > interface, mainly lack of extensibility, raciness, limited error reporting > > and absence of notifications. The goal is to allow userspace ethtool > > utility to provide all features it currently does but without using the > > ioctl interface. However, some features provided by ethtool ioctl API will > > be available through other netlink interfaces (rtnetlink, devlink) if it's > > more appropriate. > > Looks like perhaps with ETHTOOL_A_HEADER_RFLAGS checking taken out of > the picture we can proceed as is and potentially work on defining some > best practices around attrs and nesting for the future generations? :) > > I was trying to find a way to perhaps start merging something.. Would > it make sense to spin out patches 1, 2, 3, and 8 as they seem to be > ready (possibly 11, too if the reorder isn't painful)? I was surprised 3 didn't go in even last time this was posted, it seems such an obvious thing and not necessary just for ethtool :) johannes