From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91A09C433FE for ; Tue, 15 Nov 2022 18:40:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230171AbiKOSkL (ORCPT ); Tue, 15 Nov 2022 13:40:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229645AbiKOSkJ (ORCPT ); Tue, 15 Nov 2022 13:40:09 -0500 Received: from mailout-taastrup.gigahost.dk (mailout-taastrup.gigahost.dk [46.183.139.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B939F19027; Tue, 15 Nov 2022 10:40:05 -0800 (PST) Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id 0640E18841F7; Tue, 15 Nov 2022 18:40:03 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id F042725002DE; Tue, 15 Nov 2022 18:40:02 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id DF63991201E4; Tue, 15 Nov 2022 18:40:02 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 MIME-Version: 1.0 Date: Tue, 15 Nov 2022 19:40:02 +0100 From: netdev@kapio-technology.com To: Vladimir Oltean Cc: Ido Schimmel , davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Andrew Lunn , Florian Fainelli , Eric Dumazet , Paolo Abeni , open list Subject: Re: [PATCH v8 net-next 0/2] mv88e6xxx: Add MAB offload support In-Reply-To: <20221115161846.2st2kjxylfvlncib@skbuf> References: <5559fa646aaad7551af9243831b48408@kapio-technology.com> <20221115102833.ahwnahrqstcs2eug@skbuf> <7c02d4f14e59a6e26431c086a9bb9643@kapio-technology.com> <20221115111034.z5bggxqhdf7kbw64@skbuf> <0cd30d4517d548f35042a535fd994831@kapio-technology.com> <20221115122237.jfa5aqv6hauqid6l@skbuf> <20221115145650.gs7crhkidbq5ko6v@skbuf> <20221115161846.2st2kjxylfvlncib@skbuf> User-Agent: Gigahost Webmail Message-ID: X-Sender: netdev@kapio-technology.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2022-11-15 17:18, Vladimir Oltean wrote: > On Tue, Nov 15, 2022 at 05:03:01PM +0100, netdev@kapio-technology.com > wrote: >> Yes, so you want me to simply increase the 50ms on line 58 in smi.c... >> >> I have now tried to increase it even to 10000ms == 10s and it didn't >> help, >> so something else must be needed... > > Not only that, but also the one in mv88e6xxx_wait_mask(). So, I will not present you with a graph as it is a tedious process (probably it is some descending gaussian curve wrt timeout occurring). But 100ms fails, 125 I had 1 port fail, at 140, 150 and 180 I saw timeouts resulting in fdb add fails, like (and occasional port fail): mv88e6085 1002b000.ethernet-1:04: Timeout while waiting for switch mv88e6085 1002b000.ethernet-1:04: port 0 failed to add be:7c:96:06:9f:09 vid 1 to fdb: -110 At around 200 ms it looks like it is getting stable (like 5 runs, no problems). So with the gaussian curve tail whipping ones behind (risque of failure) it might need to be like 300 ms in my case... :-)