From: David Ahern <dsahern@gmail.com>
To: Ariel Levkovich <lariel@mellanox.com>, netdev@vger.kernel.org
Cc: jiri@resnulli.us, kuba@kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, ast@kernel.org, daniel@iogearbox.net,
Jiri Pirko <jiri@mellanox.com>
Subject: Re: [PATCH net-next v3 1/4] net/sched: Add skb->hash field editing via act_skbedit
Date: Tue, 14 Jul 2020 19:14:30 -0600 [thread overview]
Message-ID: <e2741150-466c-576f-5534-c20339c886e1@gmail.com> (raw)
In-Reply-To: <20200711212848.20914-2-lariel@mellanox.com>
On 7/11/20 3:28 PM, Ariel Levkovich wrote:
> @@ -156,6 +173,17 @@ static int tcf_skbedit_init(struct net *net, struct nlattr *nla,
> flags |= SKBEDIT_F_INHERITDSFIELD;
> }
>
> + if (tb[TCA_SKBEDIT_HASH] != NULL) {
> + hash_alg = nla_get_u32(tb[TCA_SKBEDIT_HASH]);
> + if (hash_alg > TCA_SKBEDIT_HASH_ALG_ASYM_L4)
> + return -EINVAL;
tcf_skbedit_init has an extack argument, so fill in a message stating
why it is failing EINVAL.
next prev parent reply other threads:[~2020-07-15 1:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-11 21:28 [PATCH net-next v3 0/4] ] TC datapath hash api Ariel Levkovich
2020-07-11 21:28 ` [PATCH net-next v3 1/4] net/sched: Add skb->hash field editing via act_skbedit Ariel Levkovich
2020-07-13 17:11 ` Davide Caratti
2020-07-15 14:25 ` Ariel Levkovich
2020-07-15 1:14 ` David Ahern [this message]
2020-07-11 21:28 ` [PATCH net-next v3 2/4] net/sched: Introduce action hash Ariel Levkovich
2020-07-13 22:04 ` Cong Wang
2020-07-14 3:17 ` Ariel Levkovich
2020-07-15 6:12 ` Cong Wang
2020-07-15 13:30 ` Ariel Levkovich
2020-07-15 18:49 ` Daniel Borkmann
2020-07-16 15:40 ` Ariel Levkovich
2020-07-11 21:28 ` [PATCH net-next v3 3/4] net/flow_dissector: add packet hash dissection Ariel Levkovich
2020-07-11 21:28 ` [PATCH net-next v3 4/4] net/sched: cls_flower: Add hash info to flow classification Ariel Levkovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2741150-466c-576f-5534-c20339c886e1@gmail.com \
--to=dsahern@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=lariel@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).