From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Bjorn Helgaas <bhelgaas@google.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-watchdog@vger.kernel.org, linux-media@vger.kernel.org,
linux-rtc@vger.kernel.org, linux-phy@lists.infradead.org,
linux-mmc@vger.kernel.org, linux-pci@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 09/11] dt-bindings: mmc: convert amlogic,meson-gx.txt to dt-schema
Date: Tue, 10 Jan 2023 11:17:52 +0100 [thread overview]
Message-ID: <e3d32fe1-9f2b-09fb-d7e0-2c8f42e5365c@linaro.org> (raw)
In-Reply-To: <20221117-b4-amlogic-bindings-convert-v2-9-36ad050bb625@linaro.org>
On 09/01/2023 13:53, Neil Armstrong wrote:
> Convert the Amlogic SD / eMMC controller for S905/GXBB family SoCs
> to dt-schema.
>
> Take in account the used variant with amlogic,meson-gx-mmc.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> .../bindings/mmc/amlogic,meson-gx-mmc.yaml | 75 ++++++++++++++++++++++
> .../devicetree/bindings/mmc/amlogic,meson-gx.txt | 39 -----------
> 2 files changed, 75 insertions(+), 39 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
> new file mode 100644
> index 000000000000..30228964fd9c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
> @@ -0,0 +1,75 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mmc/amlogic,meson-gx-mmc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Amlogic SD / eMMC controller for S905/GXBB family SoCs
> +
> +description:
> + The MMC 5.1 compliant host controller on Amlogic provides the
> + interface for SD, eMMC and SDIO devices
> +
> +maintainers:
> + - Neil Armstrong <neil.armstrong@linaro.org>
> +
> +allOf:
> + - $ref: mmc-controller.yaml#
> +
> +properties:
> + compatible:
> + oneOf:
> + - enum:
> + - amlogic,meson-gx-mmc
> + - amlogic,meson-axg-mmc
> + - items:
> + - const: amlogic,meson-gx-mmc
This does not look correct. Either gx is alone (not compatible with
gxbb) or it is compatible with gxbb. Cannot be both.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-10 10:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 12:53 [PATCH v2 00/11] dt-bindings: first batch of dt-schema conversions for Amlogic Meson bindings Neil Armstrong
2023-01-09 12:53 ` [PATCH v2 01/11] dt-bindings: firmware: convert meson_sm.txt to dt-schema Neil Armstrong
2023-01-10 10:14 ` Krzysztof Kozlowski
2023-01-09 12:53 ` [PATCH v2 02/11] dt-bindings: nvmem: convert amlogic-efuse.txt " Neil Armstrong
2023-01-10 10:15 ` Krzysztof Kozlowski
2023-01-10 22:01 ` Martin Blumenstingl
2023-01-09 12:53 ` [PATCH v2 03/11] dt-bindings: nvmem: convert amlogic-meson-mx-efuse.txt " Neil Armstrong
2023-01-10 10:15 ` Krzysztof Kozlowski
2023-01-10 22:04 ` Martin Blumenstingl
2023-01-09 12:53 ` [PATCH v2 04/11] dt-bindings: watchdog: convert meson-wdt.txt " Neil Armstrong
2023-01-10 21:48 ` Martin Blumenstingl
2023-01-23 9:42 ` Neil Armstrong
2023-01-09 12:53 ` [PATCH v2 05/11] dt-bindings: media: convert meson-ir.txt " Neil Armstrong
2023-01-09 12:53 ` [PATCH v2 06/11] dt-bindings: power: amlogic,meson-gx-pwrc: mark bindings as deprecated Neil Armstrong
2023-01-10 10:16 ` Krzysztof Kozlowski
2023-01-09 12:53 ` [PATCH v2 07/11] dt-bindings: timer: convert timer/amlogic,meson6-timer.txt to dt-schema Neil Armstrong
2023-01-09 12:53 ` [PATCH v2 08/11] dt-bindings: phy: convert meson-gxl-usb2-phy.txt " Neil Armstrong
2023-01-13 18:30 ` Vinod Koul
2023-01-09 12:53 ` [PATCH v2 09/11] dt-bindings: mmc: convert amlogic,meson-gx.txt " Neil Armstrong
2023-01-10 10:17 ` Krzysztof Kozlowski [this message]
2023-01-10 14:17 ` Neil Armstrong
2023-01-10 16:40 ` Krzysztof Kozlowski
2023-01-09 12:53 ` [PATCH v2 10/11] dt-bindings: PCI: convert amlogic,meson-pcie.txt " Neil Armstrong
2023-01-10 15:03 ` Bjorn Helgaas
2023-01-23 9:46 ` Neil Armstrong
2023-01-09 12:53 ` [PATCH v2 11/11] dt-bindings: net: convert mdio-mux-meson-g12a.txt " Neil Armstrong
2023-01-10 14:20 ` (subset) [PATCH v2 00/11] dt-bindings: first batch of dt-schema conversions for Amlogic Meson bindings Neil Armstrong
2023-01-10 23:23 ` Jakub Kicinski
2023-01-11 9:00 ` Neil Armstrong
2023-01-11 18:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3d32fe1-9f2b-09fb-d7e0-2c8f42e5365c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=bhelgaas@google.com \
--cc=daniel.lezcano@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=martin.blumenstingl@googlemail.com \
--cc=mchehab@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tglx@linutronix.de \
--cc=ulf.hansson@linaro.org \
--cc=vkoul@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).