From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AF7EC433E2 for ; Thu, 3 Sep 2020 12:43:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64AC4206EB for ; Thu, 3 Sep 2020 12:43:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cumulusnetworks.com header.i=@cumulusnetworks.com header.b="TcBFkEyt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728869AbgICMn3 (ORCPT ); Thu, 3 Sep 2020 08:43:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728843AbgICMky (ORCPT ); Thu, 3 Sep 2020 08:40:54 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 978A6C061244 for ; Thu, 3 Sep 2020 05:40:53 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id k15so3030739wrn.10 for ; Thu, 03 Sep 2020 05:40:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hBMfuDIAoT4SFwZ/3u104/lWEd/i6lIYF1PY5oM5pI0=; b=TcBFkEytJScweYUxW7dsjokpcc4dmGJTwVS80o7KJv6ybvjVYmpNSbnBfo1rYlkv1p 8A4p9XEfzZraCb80CH2BOACdX5cweDb+xG4uwrw1AnVl5WgAJtuFeWmg7b5mfqvEq/EE yRmz5CMFI+4+8U8vysnwQ8MxV0vI0it6EQmqU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hBMfuDIAoT4SFwZ/3u104/lWEd/i6lIYF1PY5oM5pI0=; b=O1BUhzcwSDuCVvNtI2b+6oskIh2xC6oGbm5bVlNmmH+0NcbSIy+EVkBxDoQHybm19l IWzuPVwKgazxZ9E9kdIQivfyqOdKvyxCP3CE5hH/VRH8AdecQf594KoWf2Gk+V1fR605 RZHNkRbmypseHYVeWRzMODDVRjSB0Sy5sOovphbovfZLwjKLmRZdyx+nL/NRafbvVIwz Fm+qoVV7ljGE4BOKuHjPatSVqjmyDPZAlysxn5eBm9B+r8XAGOKrBTTFQa707mILG2p+ Yk4UXsOWjqp2fDGxyMFxKUu0HVaRjQumZuoZL8NfwqjAXS5dgpUExuOMFsB3reqwfJM3 Evqw== X-Gm-Message-State: AOAM532Y6AgOgY3u49qKvb30MeVMqyAj/YULoLiZ3aYekgLMEmuBWL+x 987WTS8v1FkFpsNgbExOMtAhXw== X-Google-Smtp-Source: ABdhPJyV878M9c5gTjfb9X56AXRamum95oJL6lvKmmNdxfz85kj+eiMmWlXgJ9A8vOQhbT0sWY+8Mw== X-Received: by 2002:adf:b19c:: with SMTP id q28mr2444413wra.392.1599136852055; Thu, 03 Sep 2020 05:40:52 -0700 (PDT) Received: from [192.168.0.109] (84-238-136-197.ip.btc-net.bg. [84.238.136.197]) by smtp.gmail.com with ESMTPSA id o124sm4080466wmb.2.2020.09.03.05.40.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Sep 2020 05:40:51 -0700 (PDT) Subject: Re: [PATCH net-next v2 04/15] net: bridge: mcast: add support for group-and-source specific queries To: Dan Carpenter , kbuild@lists.01.org, netdev@vger.kernel.org Cc: lkp@intel.com, Dan Carpenter , kbuild-all@lists.01.org, roopa@nvidia.com, bridge@lists.linux-foundation.org, davem@davemloft.net References: <20200903121832.GD8299@kadam> From: Nikolay Aleksandrov Message-ID: Date: Thu, 3 Sep 2020 15:40:49 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200903121832.GD8299@kadam> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 03/09/2020 15:18, Dan Carpenter wrote: > Hi Nikolay, > > url: https://github.com/0day-ci/linux/commits/Nikolay-Aleksandrov/net-bridge-mcast-initial-IGMPv3-support-part-1/20200902-193339 > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git dc1a9bf2c8169d9f607502162af1858a73a18cb8 > config: i386-randconfig-m021-20200902 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > Reported-by: Dan Carpenter > > New smatch warnings: > net/bridge/br_multicast.c:359 br_ip4_multicast_alloc_query() error: use kfree_skb() here instead of kfree(skb) > > Old smatch warnings: > net/bridge/br_multicast.c:711 br_multicast_add_group() error: potential null dereference 'mp'. (br_multicast_new_group returns null) > Thanks Dan! I also caught that while working on v3 and the IPv6 part. :) Since it's in code that shouldn't be ever reached it wasn't tested. Anyway in v3 it will be fixed.