From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31EF8C433F5 for ; Fri, 6 May 2022 12:10:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1390851AbiEFMO1 (ORCPT ); Fri, 6 May 2022 08:14:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344601AbiEFMO0 (ORCPT ); Fri, 6 May 2022 08:14:26 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F123D24F03; Fri, 6 May 2022 05:10:42 -0700 (PDT) Received: from kwepemi100003.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4KvqBy0Dl1zhYvJ; Fri, 6 May 2022 20:10:18 +0800 (CST) Received: from kwepemm600016.china.huawei.com (7.193.23.20) by kwepemi100003.china.huawei.com (7.221.188.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 6 May 2022 20:10:40 +0800 Received: from [10.67.102.67] (10.67.102.67) by kwepemm600016.china.huawei.com (7.193.23.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 6 May 2022 20:10:40 +0800 Subject: Re: [PATCH net-next 3/5] net: hns3: add byte order conversion for PF to VF mailbox message To: Jakub Kicinski CC: , , , , References: <20220505124444.2233-1-huangguangbin2@huawei.com> <20220505124444.2233-4-huangguangbin2@huawei.com> <20220505184746.122aea96@kernel.org> From: "huangguangbin (A)" Message-ID: Date: Fri, 6 May 2022 20:10:40 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20220505184746.122aea96@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.102.67] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600016.china.huawei.com (7.193.23.20) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2022/5/6 9:47, Jakub Kicinski wrote: > On Thu, 5 May 2022 20:44:42 +0800 Guangbin Huang wrote: >> From: Jie Wang >> >> Currently, hns3 mailbox processing between PF and VF missed to convert >> message byte order and use data type u16 instead of __le16 for mailbox >> data process. These processes may cause problems between different >> architectures. >> >> So this patch uses __le16/__le32 data type to define mailbox data >> structures. To be compatible with old hns3 driver, these structures use >> one-byte alignment. Then byte order conversions are added to mailbox >> messages from PF to VF. > > This adds a few sparse [1] warnings, you must have missed a few > conversions. > > Please wait at least 24h for additional feedback before reposting. > > [1] https://www.kernel.org/doc/html/latest/dev-tools/sparse.html > > . > Ok, thanks