From: Hayes Wang <hayeswang@realtek.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>
Subject: RE: [PATCH 0/2] r8152: Fix a couple of PM problems
Date: Thu, 15 Jul 2021 04:36:51 +0000 [thread overview]
Message-ID: <e6cf8c26165a489bbf704946765ac3bd@realtek.com> (raw)
In-Reply-To: <162630000449.32220.17532101783175093246.git-patchwork-notify@kernel.org>
> Subject: Re: [PATCH 0/2] r8152: Fix a couple of PM problems
[...]
>
> Here is the summary with links:
> - [1/2] r8152: Fix potential PM refcount imbalance
> https://git.kernel.org/netdev/net/c/9c23aa51477a
> - [2/2] r8152: Fix a deadlock by doubly PM resume
> https://git.kernel.org/netdev/net/c/776ac63a986d
I think set_ethernet_addr() shouldn't be called at reset-resume.
The MAC address should be restored to the current one, not the
default value. Someone may change the MAC address before suspending.
And the MAC address would become the default value after reset-resume,
if set_ethernet_addr() is called.
Best Regards,
Hayes
prev parent reply other threads:[~2021-07-15 4:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 17:00 [PATCH 0/2] r8152: Fix a couple of PM problems Takashi Iwai
2021-07-14 17:00 ` [PATCH 1/2] r8152: Fix potential PM refcount imbalance Takashi Iwai
2021-07-14 17:00 ` [PATCH 2/2] r8152: Fix a deadlock by doubly PM resume Takashi Iwai
2021-07-14 22:00 ` [PATCH 0/2] r8152: Fix a couple of PM problems patchwork-bot+netdevbpf
2021-07-15 4:36 ` Hayes Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6cf8c26165a489bbf704946765ac3bd@realtek.com \
--to=hayeswang@realtek.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).