From: Zhang Changzhong <zhangchangzhong@huawei.com>
To: Marion & Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
<jcliburn@gmail.com>, <chris.snook@gmail.com>,
<davem@davemloft.net>, <kuba@kernel.org>, <mst@redhat.com>,
<leon@kernel.org>, <hkallweit1@gmail.com>, <tglx@linutronix.de>,
<jesse.brandeburg@intel.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] atl1e: fix error return code in atl1e_probe()
Date: Wed, 18 Nov 2020 11:25:25 +0800 [thread overview]
Message-ID: <e7a0300f-056d-f952-c4d6-609b488b3e9c@huawei.com> (raw)
In-Reply-To: <b7b4dcd3-a536-b72f-6a8b-12354c995ee7@wanadoo.fr>
On 2020/11/18 4:38, Marion & Christophe JAILLET wrote:
>
> Le 17/11/2020 à 03:57, Zhang Changzhong a écrit :
>> Fix to return a negative error code from the error handling
>> case instead of 0, as done elsewhere in this function.
>>
>> Fixes: 85eb5bc33717 ("net: atheros: switch from 'pci_' to 'dma_' API")
> Hi, should it have any importance, the Fixes tag is wrong.
>
> The issue was already there before 85eb5bc33717 which was just a mechanical update.
>
> just my 2c
>
> CJ
>
Thanks for reminding, the correct Fixes tag should be:
Fixes: a6a5325239c2 ("atl1e: Atheros L1E Gigabit Ethernet driver"
next prev parent reply other threads:[~2020-11-18 3:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 2:57 [PATCH net] atl1e: fix error return code in atl1e_probe() Zhang Changzhong
2020-11-17 20:38 ` Marion & Christophe JAILLET
2020-11-18 3:25 ` Zhang Changzhong [this message]
2020-11-18 19:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7a0300f-056d-f952-c4d6-609b488b3e9c@huawei.com \
--to=zhangchangzhong@huawei.com \
--cc=chris.snook@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=jcliburn@gmail.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).