From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2204AC169C4 for ; Fri, 8 Feb 2019 13:40:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E62FA20844 for ; Fri, 8 Feb 2019 13:40:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726747AbfBHNkE (ORCPT ); Fri, 8 Feb 2019 08:40:04 -0500 Received: from www62.your-server.de ([213.133.104.62]:59070 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726456AbfBHNkE (ORCPT ); Fri, 8 Feb 2019 08:40:04 -0500 Received: from [78.46.172.3] (helo=sslproxy06.your-server.de) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1gs6Nt-0004N6-7g; Fri, 08 Feb 2019 14:40:01 +0100 Received: from [2a02:1203:ecb1:b710:c81f:d2d6:50a9:c2d] (helo=linux.home) by sslproxy06.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1gs6Nt-000LiK-23; Fri, 08 Feb 2019 14:40:01 +0100 Subject: Re: [PATCH net-next] ipvlan: decouple l3s mode dependencies from other modes To: Florian Westphal Cc: davem@davemloft.net, netdev@vger.kernel.org, Mahesh Bandewar , Martynas Pumputis References: <20190208125531.28970-1-daniel@iogearbox.net> <20190208132941.bmbvuqckocuyhujr@breakpoint.cc> From: Daniel Borkmann Message-ID: Date: Fri, 8 Feb 2019 14:39:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20190208132941.bmbvuqckocuyhujr@breakpoint.cc> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.100.2/25354/Fri Feb 8 11:45:07 2019) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 02/08/2019 02:29 PM, Florian Westphal wrote: > Daniel Borkmann wrote: >> Right now ipvlan has a hard dependency on CONFIG_NETFILTER and >> otherwise it cannot be built. However, the only ipvlan operation >> mode that actually depends on netfilter is l3s, everything else >> is independent of it. Break this hard dependency such that users >> are able to use ipvlan l3 mode on systems where netfilter is not >> compiled in. >> >> Therefore, this adds a hidden CONFIG_IPVLAN_L3S bool which is >> defaulting to y when CONFIG_NETFILTER is set in order to retain >> existing behavior for l3s. All l3s related code is refactored >> into ipvlan_l3s.c that is compiled in when enabled. > > IIRC L3S is only meaningful with netfilter anyway, so this > looks like a good thing to do. Yep, agree, it doesn't work without it since inside ipvlan's nfhook there is the final switch to the target ipvlan slave device. :) > Acked-by: Florian Westphal Thanks!