From: "Slark Xiao" <slark_xiao@163.com>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re:Re: [PATCH] net: usb: qmi_wwan: Add support for Cinterion MV32
Date: Wed, 10 Aug 2022 17:28:51 +0800 (CST) [thread overview]
Message-ID: <e7fdcfc.30e7.1828715d7af.Coremail.slark_xiao@163.com> (raw)
In-Reply-To: <8735e4mvtd.fsf@miraculix.mork.no>
At 2022-08-10 14:55:42, "Bjørn Mork" <bjorn@mork.no> wrote:
>Slark Xiao <slark_xiao@163.com> writes:
>
>> There are 2 models for MV32 serials. MV32-W-A is designed
>> based on Qualcomm SDX62 chip, and MV32-W-B is designed based
>> on Qualcomm SDX65 chip. So we use 2 different PID to separate it.
>>
>> Test evidence as below:
>> T: Bus=03 Lev=01 Prnt=01 Port=02 Cnt=03 Dev#= 3 Spd=480 MxCh= 0
>> D: Ver= 2.10 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1
>> P: Vendor=1e2d ProdID=00f3 Rev=05.04
>> S: Manufacturer=Cinterion
>> S: Product=Cinterion PID 0x00F3 USB Mobile Broadband
>> S: SerialNumber=d7b4be8d
>> C: #Ifs= 4 Cfg#= 1 Atr=a0 MxPwr=500mA
>> I: If#=0x0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=50 Driver=qmi_wwan
>> I: If#=0x1 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=40 Driver=option
>> I: If#=0x2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=40 Driver=option
>> I: If#=0x3 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=30 Driver=option
>
>The patch looks nice, but I have a couple of questions since you're one
>of the first pushing one of these SDX6x modems.
>
>Is that protocol pattern fixed on this generation of Qualcomm chips? It
>looks like an extension of what they started with the SDX55 generation,
>where the DIAG port was identified by ff/ff/30 across multiple vendors.
>
Seems yes. I checked some different usb_compositions and found that
diag port is using protocol '30' always.
>Specifically wrt this driver and patch, I wonder if we can/should match
>on ff/ff/50 instead of interface number here? I note that the interface
I checked all our edited usb_compositions and all QC default usb
compositions(9025, 90db, 9067,90d5,9084,9091,90ad,90b8,90e5),
ff/ff/50 is rmnet used only.
>numbers are allocated sequentionally. Probably in the order these
>function are enabled by the firmware? If so, are we sure this is static?
This needs more time to confirm. I will keep you updated.
>Or could we risk config variants where the RMNET/QMI function have a
>different interface number for the same PIDs?
>
>And another possibility you might consider. Assuming that ff/ff/50
>uniquely identifies RMNET/QMI functions regardless of PID, would you
>consider a VID+class match to catch all of them? This would not only
>support both the PIDs of this patch in one go, but also any future PIDs
>without the need for further driver patches.
>
>
>Bjørn
I have a concern, if Cinterion or other Vendors, like Quectel, use other
chip (such as intel, mediateck and so on), this methods may won't work,
because they share a same VID. Also this may be changed once Qualcomm
update the protocol patterns for future chip.
next prev parent reply other threads:[~2022-08-10 9:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 1:45 [PATCH] net: usb: qmi_wwan: Add support for Cinterion MV32 Slark Xiao
2022-08-10 6:55 ` Bjørn Mork
2022-08-10 9:28 ` Slark Xiao [this message]
2022-08-10 9:41 ` Slark Xiao
2022-08-10 12:35 ` Bjørn Mork
2022-08-11 8:07 ` Slark Xiao
2022-08-11 8:27 ` Bjørn Mork
2022-08-11 16:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7fdcfc.30e7.1828715d7af.Coremail.slark_xiao@163.com \
--to=slark_xiao@163.com \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).