From: Jamal Hadi Salim <jhs@mojatatu.com>
To: David Ahern <dsahern@gmail.com>,
Stephen Hemminger <stephen@networkplumber.org>,
netdev@vger.kernel.org, victor@mojatatu.com,
Davide Caratti <dcaratti@redhat.com>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Vlad Buslov <vladbu@nvidia.com>
Subject: Re: [PATCH v2 iproute2-next 00/11] clang warning fixes
Date: Mon, 17 Jan 2022 10:29:02 -0500 [thread overview]
Message-ID: <e8e78f5e-748b-6db4-7abe-4ccbf70eaaf0@mojatatu.com> (raw)
In-Reply-To: <95299213-6768-e9ed-ea82-1ecb903d86e3@gmail.com>
On 2022-01-16 18:18, David Ahern wrote:
> On 1/11/22 10:54 AM, Stephen Hemminger wrote:
>> This patch set makes iproute2-next main branch compile without warnings
>> on Clang 11 (and probably later versions).
>>
>> Still needs more testing before merge. There are likely to be some
>> unnecessary output format changes from this.
>>
>
> I think the tc patches are the only likely candidates. The
> print_string_name_value conversion should be clean.
>
> Jamal: As I recall you have a test suite for tc. Can you test this set?
We try to push, whenever we can, to kernel tdc tests. The Intel robot
should catch issues based on what we have there. If we make part of the
acceptance process (incumbent on people who create the patches) to
run those tests it would help getting cleaner submissions. Not sure
if we can have a bot doing this..
Punting to Victor(on Cc) to run the tests and double check if we
have test cases that cover for these changes.
cheers,
jamal
next prev parent reply other threads:[~2022-01-17 15:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 17:54 [PATCH v2 iproute2-next 00/11] clang warning fixes Stephen Hemminger
2022-01-11 17:54 ` [PATCH v2 iproute2-next 01/11] tc: add format attribute to tc_print_rate Stephen Hemminger
2022-01-11 17:54 ` [PATCH v2 iproute2-next 02/11] utils: add format attribute Stephen Hemminger
2022-01-11 17:54 ` [PATCH v2 iproute2-next 03/11] netem: fix clang warnings Stephen Hemminger
2022-01-11 17:54 ` [PATCH v2 iproute2-next 04/11] flower: " Stephen Hemminger
2022-01-11 17:54 ` [PATCH v2 iproute2-next 05/11] tc_util: fix clang warning in print_masked_type Stephen Hemminger
2022-01-11 17:54 ` [PATCH v2 iproute2-next 06/11] ipl2tp: fix clang warning Stephen Hemminger
2022-01-11 17:54 ` [PATCH v2 iproute2-next 07/11] can: " Stephen Hemminger
2022-01-11 17:54 ` [PATCH v2 iproute2-next 08/11] tipc: fix clang warning about empty format string Stephen Hemminger
2022-01-11 17:54 ` [PATCH v2 iproute2-next 09/11] tunnel: fix clang warning Stephen Hemminger
2022-01-11 17:54 ` [PATCH v2 iproute2-next 10/11] libbpf: fix clang warning about format non-literal Stephen Hemminger
2022-01-11 17:54 ` [PATCH v2 iproute2-next 11/11] json_print: suppress clang format warning Stephen Hemminger
2022-01-16 23:18 ` [PATCH v2 iproute2-next 00/11] clang warning fixes David Ahern
2022-01-17 0:33 ` Stephen Hemminger
2022-01-17 15:29 ` Jamal Hadi Salim [this message]
2022-01-20 12:48 ` Victor Nogueira
2022-01-20 19:20 ` David Ahern
2022-01-20 20:21 ` Victor Nogueira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8e78f5e-748b-6db4-7abe-4ccbf70eaaf0@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=dcaratti@redhat.com \
--cc=dsahern@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=victor@mojatatu.com \
--cc=vladbu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).