From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE157C432C0 for ; Wed, 27 Nov 2019 06:12:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5A7D2206F0 for ; Wed, 27 Nov 2019 06:12:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=geanix.com header.i=@geanix.com header.b="JiLeNeeG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726135AbfK0GMt (ORCPT ); Wed, 27 Nov 2019 01:12:49 -0500 Received: from first.geanix.com ([116.203.34.67]:57816 "EHLO first.geanix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726026AbfK0GMt (ORCPT ); Wed, 27 Nov 2019 01:12:49 -0500 Received: from [192.168.100.95] (unknown [95.138.208.137]) by first.geanix.com (Postfix) with ESMTPSA id 0928893B1C; Wed, 27 Nov 2019 06:09:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=geanix.com; s=first; t=1574834944; bh=emaCv2J/HHG0hWeBdetGv++669/Op4JbuFqbXvfzMrY=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=JiLeNeeG1zjXa+qq+M6lYOIR0LUax596aJIruSTqO21+KrggRfsxonHoJ+PCZcUOL hb+8LP8vrwNgYDYzVpdiEQ7AJ231cATtlC76V0WKRTQMIUgisuGUri2O6ufzqw2D5J Y4ri/ZH2PHuA9o1/AZx5q8KLInW4jDY+JAgKpWYkrmUK6R/NmsVq7i+n/MKGfegKC9 LA4oVJ/LMDXa3w0c8TcVd7tS8/IVMRrD36nRil+/mZkQ1Qab+x61Hpa4MCWOhxvnBy bo0zNa72MIQWkf7cvwmkhzw1NP+JPXiupqAxtH+jONeIib9tblmsIKiqcrM2p4JmWv jV/E2p68hqucg== Subject: Re: [PATCH V2 0/4] can: flexcan: fixes for stop mode To: Joakim Zhang , "mkl@pengutronix.de" , "linux-can@vger.kernel.org" Cc: dl-linux-imx , "netdev@vger.kernel.org" References: <20191127055334.1476-1-qiangqing.zhang@nxp.com> From: Sean Nyekjaer Message-ID: Date: Wed, 27 Nov 2019 07:12:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191127055334.1476-1-qiangqing.zhang@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US-large Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 27/11/2019 06.56, Joakim Zhang wrote: > Could you help check the patch set? With your suggestions, I > have cooked a patch to exit stop mode during probe stage. > > IMHO, I think this patch is unneed, now in flexcan driver, > enter stop mode when suspend, and then exit stop mode when resume. > AFAIK, as long as flexcan_suspend has been called, flexcan_resume will > be called, unless the system hang during suspend/resume. If so, only > code reset can activate OS again. Could you please tell me how does CAN > stucked in stop mode at your side? Hi Joakim, Thanks I'll test this :-) Guess I will have do some hacking to get it stuck in stop mode. We have a lot of devices in the field that doesn't have: "can: flexcan: fix deadlock when using self wakeup" And they have traffic on both CAN interfaces, that way it's quite easy to get them stuck in stop mode. /Sean