From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9E14C433FE for ; Sat, 19 Nov 2022 20:47:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234444AbiKSUrg (ORCPT ); Sat, 19 Nov 2022 15:47:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235148AbiKSUrd (ORCPT ); Sat, 19 Nov 2022 15:47:33 -0500 Received: from mx10lb.world4you.com (mx10lb.world4you.com [81.19.149.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A59E013D32 for ; Sat, 19 Nov 2022 12:47:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=engleder-embedded.com; s=dkim11; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Y+z/ckFz8kQeTSdijIKzkj1sQSAZqk8w8VZ2RCgN15s=; b=A+z+/QYi5FASmBFCSkGQg9oKio 4CSMOsf2QPaxl7Azqsqmh281P+s9SAgGMtu172ds+MNhOh3hI4ry+buU66jZWAKya5NdXxc1RiXgR Hepr/IQqv0mJekKNYnX5yyCoP4E7S8PSA04MiYG3wLclyvu/i86/3e5p9hyJbPiHvxuk=; Received: from [88.117.56.227] (helo=[10.0.0.160]) by mx10lb.world4you.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1owUkM-0006Wx-36; Sat, 19 Nov 2022 21:47:30 +0100 Message-ID: Date: Sat, 19 Nov 2022 21:47:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH net-next 2/4] tsnep: Fix rotten packets Content-Language: en-US To: Jakub Kicinski Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com References: <20221117201440.21183-1-gerhard@engleder-embedded.com> <20221117201440.21183-3-gerhard@engleder-embedded.com> <20221118172618.34c7097e@kernel.org> From: Gerhard Engleder In-Reply-To: <20221118172618.34c7097e@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AV-Do-Run: Yes Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 19.11.22 02:26, Jakub Kicinski wrote: > On Thu, 17 Nov 2022 21:14:38 +0100 Gerhard Engleder wrote: >> If PTP synchronisation is done every second, then sporadic the interval >> is higher than one second: >> >> ptp4l[696.582]: master offset -17 s2 freq -1891 path delay 573 >> ptp4l[697.582]: master offset -22 s2 freq -1901 path delay 573 >> ptp4l[699.368]: master offset -1 s2 freq -1887 path delay 573 >> ^^^^^^^ Should be 698.582! >> >> This problem is caused by rotten packets, which are received after >> polling but before interrupts are enabled again. This can be fixed by >> checking for pending work and rescheduling if necessary after interrupts >> has been enabled again. >> >> Fixes: 403f69bbdbad ("tsnep: Add TSN endpoint Ethernet MAC driver") >> Signed-off-by: Gerhard Engleder > > This patch needs to go to net separately :( > Packets getting stuck in a queue can cause real issues to users. I will post it separately.