From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1613BC54EBD for ; Mon, 9 Jan 2023 18:24:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236667AbjAISXp (ORCPT ); Mon, 9 Jan 2023 13:23:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237472AbjAISXE (ORCPT ); Mon, 9 Jan 2023 13:23:04 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DEF613CD1 for ; Mon, 9 Jan 2023 10:22:09 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id co23so9117244wrb.4 for ; Mon, 09 Jan 2023 10:22:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jvYugD5smOlPeb8yw4a3uYKIpMLS5cDQVS3icNcFMKA=; b=Z6PyaEpVm6gQZPhyOA+umXIzP1gj2ivonb832kvaPK2LHBAyLgqzEzWs+trmEE0Jln khMmlms5Uv6PhL4q8PhFwsygO3DHLGc4l5gyw4ZBVAMxJaFNOTa/D+37v6hQEgNUi6HJ MwrpiJXqxUpvHZ/jLL+pwFgBfNyRIeOFG6BE2kS+7uUlUG3H6z1r5xzHXB+rv1s49c7Z /cxqXGU2xlMj3qBcL9i+f7FQf/GhDu4ibCR+/YuG/aUITAgdMLmIeG9x8sQ8tEVru5a6 NNDcVLsWYktntSaFMN0HlSbfAEBeUesEeaNrLaNMlba8+UyRhbCP48f1qqKf5QYGnay+ VoIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jvYugD5smOlPeb8yw4a3uYKIpMLS5cDQVS3icNcFMKA=; b=gAk16PwKI5ltFK6x/DPvcaoU8UxiHHYHy29ItO6FJM6dpjBXHy2//nfy6VvVOWvBdL I2M1ZBONfFcbFvnrFUPUM/K5V4bD+LWmIpToYYc8Z3Cnbu14hCKlY0UcIdvknh8jYNqr brwuXd60kifdK14+e+NDhwVYR1XefGHJyHjq//BENW6f24bjTUUF9WhaQjBpUVN9pzyd ssGhXWgMeaHE2jY78OZN1zg36lomWbr1ckNhmD+r6UFsje16WQ8Bu2w3TzDXCjYPxNPR BB8LBz5PV8v93JYiPB/XMtszjOPtiVNt7dQblUYc+W0uVp7br2FHQ+7LlzxtT76tOhiv b1hA== X-Gm-Message-State: AFqh2kqd4wQp2nhJd/yavoNBvvsnB8gG2XaYo6s9QV76XwjMzlquZ6k6 z8SkbZzNlaryw0M0exZl/S4l0Q== X-Google-Smtp-Source: AMrXdXvjfzGBA2k+30sjPaP84E+50hgotZRZMLKqmz8cAfThUKaz2IKhBGPXhX7+mGfJd+LOudPNGg== X-Received: by 2002:a5d:5544:0:b0:26d:2af7:420 with SMTP id g4-20020a5d5544000000b0026d2af70420mr40676769wrw.33.1673288528036; Mon, 09 Jan 2023 10:22:08 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id o15-20020a5d62cf000000b002bbedd60a9asm3589168wrv.77.2023.01.09.10.22.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Jan 2023 10:22:07 -0800 (PST) Message-ID: Date: Mon, 9 Jan 2023 19:22:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 07/18] interconnect: qcom: add a driver for sa8775p Content-Language: en-US To: Bartosz Golaszewski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Georgi Djakov , Will Deacon , Robin Murphy , Joerg Roedel , Manivannan Sadhasivam , Jassi Brar , Linus Walleij , Catalin Marinas , Richard Cochran , Srinivas Kandagatla , Vinod Koul , Alex Elder Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, Shazad Hussain , Bartosz Golaszewski References: <20230109174511.1740856-1-brgl@bgdev.pl> <20230109174511.1740856-8-brgl@bgdev.pl> From: Krzysztof Kozlowski In-Reply-To: <20230109174511.1740856-8-brgl@bgdev.pl> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 09/01/2023 18:45, Bartosz Golaszewski wrote: > From: Shazad Hussain > > Introduce QTI SA8775P-specific interconnect driver. > > + > +static struct qcom_icc_desc sa8775p_pcie_anoc = { > + .nodes = pcie_anoc_nodes, > + .num_nodes = ARRAY_SIZE(pcie_anoc_nodes), > + .bcms = pcie_anoc_bcms, > + .num_bcms = ARRAY_SIZE(pcie_anoc_bcms), > +}; > + > +static struct qcom_icc_bcm *system_noc_bcms[] = { > + &bcm_sn0, > + &bcm_sn1, > + &bcm_sn3, > + &bcm_sn4, > + &bcm_sn9, > +}; > + > +static struct qcom_icc_node *system_noc_nodes[] = { > + [MASTER_GIC_AHB] = &qhm_gic, > + [MASTER_A1NOC_SNOC] = &qnm_aggre1_noc, > + [MASTER_A2NOC_SNOC] = &qnm_aggre2_noc, > + [MASTER_LPASS_ANOC] = &qnm_lpass_noc, > + [MASTER_SNOC_CFG] = &qnm_snoc_cfg, > + [MASTER_PIMEM] = &qxm_pimem, > + [MASTER_GIC] = &xm_gic, > + [SLAVE_SNOC_GEM_NOC_GC] = &qns_gemnoc_gc, > + [SLAVE_SNOC_GEM_NOC_SF] = &qns_gemnoc_sf, > + [SLAVE_SERVICE_SNOC] = &srvc_snoc, > +}; > + > +static struct qcom_icc_desc sa8775p_system_noc = { This and several others are const, which means you started entire work on some old code. It's quite a waste of your effort as now you have to get all the patches we did for cleanups. Much better to start off from a newest file. If you based work on downstream code, then this definitely needs many fixes... Best regards, Krzysztof