From: Matt Johnston <matt@codeconstruct.com.au>
To: Wolfram Sang <wsa@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jeremy Kerr <jk@codeconstruct.com.au>,
linux-i2c@vger.kernel.org, netdev@vger.kernel.org,
Zev Weiss <zev@bewilderbeest.net>
Subject: Re: [PATCH net-next v5 2/2] mctp i2c: MCTP I2C binding driver
Date: Thu, 17 Feb 2022 15:39:37 +0800 [thread overview]
Message-ID: <eaee265147f14982c89d400f80e4482a029cdf98.camel@codeconstruct.com.au> (raw)
In-Reply-To: <Yg0jMkt56EhrBybc@ninjato>
Hi Wolfram,
On Wed, 2022-02-16 at 17:15 +0100, Wolfram Sang wrote:
> So, I did a high level review regardings the I2C stuff. I did not check
> locking, device lifetime, etc. My biggest general remark is the mixture
> of multi-comment styles, like C++ style or no empty "/*" at the
> beginning as per Kernel coding style. Some functions have nice
> explanations in the header but not proper kdoc formatting. And also on
> the nitbit side, I don't think '__func__' helps here on the error
> messages. But that's me, I'll leave it to the netdev maintainers.
I'll tidy up the comments. A filled /* first line is part of the netdev
style.
>
> Now for the I2C part. It looks good. I have only one remark:
>
> > +static const struct i2c_device_id mctp_i2c_id[] = {
> > + { "mctp-i2c", 0 },
> > + {},
> > +};
> > +MODULE_DEVICE_TABLE(i2c, mctp_i2c_id);
>
> ...
>
> > +static struct i2c_driver mctp_i2c_driver = {
> > + .driver = {
> > + .name = "mctp-i2c",
> > + .of_match_table = mctp_i2c_of_match,
> > + },
> > + .probe_new = mctp_i2c_probe,
> > + .remove = mctp_i2c_remove,
> > + .id_table = mctp_i2c_id,
> > +};
>
> I'd suggest to add 'slave' to the 'mctp-i2c' string somewhere to make it
> easily visible that this driver does not manage a remote device but
> processes requests to its own address.
I think 'slave' might be a bit unclear - the driver's acting as an I2C master
too. It also is more baggage moving to inclusive naming. Maybe mctp-i2c-
transport or mctp-i2c-interface would suit?
Cheers,
Matt
next prev parent reply other threads:[~2022-02-17 7:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 6:36 [PATCH net-next v5 0/2] MCTP I2C driver Matt Johnston
2022-02-10 6:36 ` [PATCH net-next v5 1/2] dt-bindings: net: New binding mctp-i2c-controller Matt Johnston
2022-02-10 14:41 ` Rob Herring
2022-02-16 15:54 ` Wolfram Sang
2022-02-10 6:36 ` [PATCH net-next v5 2/2] mctp i2c: MCTP I2C binding driver Matt Johnston
2022-02-11 22:38 ` Jakub Kicinski
2022-02-15 4:22 ` Matt Johnston
2022-02-15 5:04 ` Jakub Kicinski
2022-02-15 10:01 ` Matt Johnston
2022-02-15 15:58 ` Jakub Kicinski
2022-02-16 16:15 ` Wolfram Sang
2022-02-17 7:39 ` Matt Johnston [this message]
2022-02-17 8:58 ` Wolfram Sang
2022-02-17 9:22 ` Matt Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaee265147f14982c89d400f80e4482a029cdf98.camel@codeconstruct.com.au \
--to=matt@codeconstruct.com.au \
--cc=davem@davemloft.net \
--cc=jk@codeconstruct.com.au \
--cc=kuba@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wsa@kernel.org \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).