From: David Ahern <dsahern@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>, David Ahern <dsahern@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, schoen@loyalty.org
Subject: Re: [PATCH net-next v3 06/13] selftests: Use separate stdout and stderr buffers in nettest
Date: Wed, 13 Jan 2021 17:08:03 -0700 [thread overview]
Message-ID: <ecc131c9-f60d-5f89-9c1a-3bd77907e822@gmail.com> (raw)
In-Reply-To: <20210113155652.5fd41775@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 1/13/21 4:56 PM, Jakub Kicinski wrote:
>> diff --git a/tools/testing/selftests/net/nettest.c b/tools/testing/selftests/net/nettest.c
>> index 685cbe8933de..9114bc823092 100644
>> --- a/tools/testing/selftests/net/nettest.c
>> +++ b/tools/testing/selftests/net/nettest.c
>> @@ -1707,9 +1707,27 @@ static char *random_msg(int len)
>>
>> static int ipc_child(int fd, struct sock_args *args)
>> {
>> + char *outbuf, *errbuf;
>> + int rc;
>> +
>> + outbuf = malloc(4096);
>> + errbuf = malloc(4096);
>> + if (!outbuf || !errbuf) {
>> + fprintf(stderr, "server: Failed to allocate buffers for stdout and stderr\n");
>> + return 1;
>
> So this patch did not change? Did you send the wrong version,
> or am I missing something?
>
yes, I did. Will send a v4 later.
next prev parent reply other threads:[~2021-01-14 1:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 4:00 [PATCH net-next v3 00/13] selftests: Updates to allow single instance of nettest for client and server David Ahern
2021-01-13 4:00 ` [PATCH net-next v3 01/13] selftests: Move device validation in nettest David Ahern
2021-01-13 4:00 ` [PATCH net-next v3 02/13] selftests: Move convert_addr up " David Ahern
2021-01-13 4:00 ` [PATCH net-next v3 03/13] selftests: Move address validation " David Ahern
2021-01-13 4:00 ` [PATCH net-next v3 04/13] selftests: Add options to set network namespace to nettest David Ahern
2021-01-13 4:00 ` [PATCH net-next v3 05/13] selftests: Add support to nettest to run both client and server David Ahern
2021-01-13 4:00 ` [PATCH net-next v3 06/13] selftests: Use separate stdout and stderr buffers in nettest David Ahern
2021-01-13 23:56 ` Jakub Kicinski
2021-01-14 0:08 ` David Ahern [this message]
2021-01-13 4:00 ` [PATCH net-next v3 07/13] selftests: Add missing newline in nettest error messages David Ahern
2021-01-13 4:00 ` [PATCH net-next v3 08/13] selftests: Make address validation apply only to client mode David Ahern
2021-01-13 4:00 ` [PATCH net-next v3 09/13] selftests: Consistently specify address for MD5 protection David Ahern
2021-01-13 4:00 ` [PATCH net-next v3 10/13] selftests: Add new option for client-side passwords David Ahern
2021-01-13 4:00 ` [PATCH net-next v3 11/13] selftests: Add separate options for server device bindings David Ahern
2021-01-13 4:00 ` [PATCH net-next v3 12/13] selftests: Remove exraneous newline in nettest David Ahern
2021-01-13 4:00 ` [PATCH net-next v3 13/13] selftests: Add separate option to nettest for address binding David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecc131c9-f60d-5f89-9c1a-3bd77907e822@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=schoen@loyalty.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).