From: Allen Pais <apais@linux.microsoft.com>
To: Jakub Kicinski <kuba@kernel.org>, Allen Pais <allen.lkml@gmail.com>
Cc: davem@davemloft.net, m.grzeschik@pengutronix.de,
paulus@samba.org, oliver@neukum.org, woojung.huh@microchip.com,
UNGLinuxDriver@microchip.com, petkan@nucleusys.com,
netdev@vger.kernel.org, Romain Perier <romain.perier@gmail.com>
Subject: Re: [next-next v3 05/10] net: cdc_ncm: convert tasklets to use new tasklet_setup() API
Date: Tue, 3 Nov 2020 13:02:26 +0530 [thread overview]
Message-ID: <ed37373b-218c-600d-7837-efdd217fd799@linux.microsoft.com> (raw)
In-Reply-To: <20201008165859.2e96ef7c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
>
>> @@ -815,7 +815,7 @@ int cdc_ncm_bind_common(struct usbnet *dev, struct usb_interface *intf, u8 data_
>>
>> hrtimer_init(&ctx->tx_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
>> ctx->tx_timer.function = &cdc_ncm_tx_timer_cb;
>> - tasklet_init(&ctx->bh, cdc_ncm_txpath_bh, (unsigned long)dev);
>> + tasklet_setup(&ctx->bh, cdc_ncm_txpath_bh);
>> atomic_set(&ctx->stop, 0);
>> spin_lock_init(&ctx->mtx);
>>
>> @@ -1468,9 +1468,9 @@ static enum hrtimer_restart cdc_ncm_tx_timer_cb(struct hrtimer *timer)
>> return HRTIMER_NORESTART;
>> }
>>
>> -static void cdc_ncm_txpath_bh(unsigned long param)
>> +static void cdc_ncm_txpath_bh(struct tasklet_struct *t)
>> {
>> - struct usbnet *dev = (struct usbnet *)param;
>> + struct usbnet *dev = from_tasklet(dev, t, bh);
>> struct cdc_ncm_ctx *ctx = (struct cdc_ncm_ctx *)dev->data[0];
>>
>> spin_lock_bh(&ctx->mtx);
>
> This one is wrong.
>
> ctx is struct cdc_ncm_ctx, but you from_tasklet() struct usbdev.
> They both happen to have a tasklet called bh in 'em.
from_tasklet() is struct usbnet. So it should pick the right bh isn't it?
Thanks.
next prev parent reply other threads:[~2020-11-03 7:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 6:11 [next-next v3 00/10] drivers: net: convert tasklets to use new Allen Pais
2020-10-06 6:11 ` [next-next v3 01/10] net: arcnet: convert tasklets to use new tasklet_setup() API Allen Pais
2020-10-06 6:11 ` [next-next v3 02/10] net: caif: " Allen Pais
2020-10-06 6:11 ` [next-next v3 03/10] net: ifb: " Allen Pais
2020-10-06 6:11 ` [next-next v3 04/10] net: ppp: " Allen Pais
2020-10-06 6:11 ` [next-next v3 05/10] net: cdc_ncm: " Allen Pais
2020-10-08 23:58 ` Jakub Kicinski
2020-11-03 7:32 ` Allen Pais [this message]
2020-11-03 15:55 ` Jakub Kicinski
2020-10-06 6:11 ` [next-next v3 06/10] net: hso: " Allen Pais
2020-10-06 6:11 ` [next-next v3 07/10] net: lan78xx: " Allen Pais
2020-10-06 6:11 ` [next-next v3 08/10] net: pegasus: " Allen Pais
2020-10-06 6:11 ` [next-next v3 09/10] net: r8152: " Allen Pais
2020-10-06 6:11 ` [next-next v3 10/10] net: rtl8150: " Allen Pais
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed37373b-218c-600d-7837-efdd217fd799@linux.microsoft.com \
--to=apais@linux.microsoft.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=allen.lkml@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=paulus@samba.org \
--cc=petkan@nucleusys.com \
--cc=romain.perier@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).