From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net-next 2/3] tcp: implement coalescing on backlog queue
Date: Wed, 21 Nov 2018 14:40:03 -0800
Message-ID: <ed3b38f5-14f9-2cae-b52d-35fd011ebcf0@gmail.com>
References: <20181121175240.6075-1-edumazet@google.com>
 <20181121175240.6075-3-edumazet@google.com>
 <CAK6E8=en_sPbKnb60YnPYrVBYKY1doG_V-FFgzrbAv4gnQwy5w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "David S . Miller" <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>,
        Jean-Louis Dupond <jean-louis@dupond.be>,
        Neal Cardwell <ncardwell@google.com>
To: Yuchung Cheng <ycheng@google.com>,
        Eric Dumazet <edumazet@google.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl1-f195.google.com ([209.85.214.195]:34183 "EHLO
        mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1731883AbeKVJQ2 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 22 Nov 2018 04:16:28 -0500
Received: by mail-pl1-f195.google.com with SMTP id f12-v6so7465516plo.1
        for <netdev@vger.kernel.org>; Wed, 21 Nov 2018 14:40:05 -0800 (PST)
In-Reply-To: <CAK6E8=en_sPbKnb60YnPYrVBYKY1doG_V-FFgzrbAv4gnQwy5w@mail.gmail.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 11/21/2018 02:31 PM, Yuchung Cheng wrote:
> On Wed, Nov 21, 2018 at 9:52 AM, Eric Dumazet <edumazet@google.com> wrote:

>> +
> Really nice! would it make sense to re-use (some of) the similar
> tcp_try_coalesce()?
>

Maybe, but it is a bit complex, since skbs in receive queues (regular or out of order)
are accounted differently (they have skb->destructor set)

Also they had the TCP header pulled already, while the backlog coalescing also has
to make sure TCP options match.

Not sure if we want to add extra parameters and conditional checks...