From: Jens Axboe <axboe@kernel.dk>
To: Sascha Hauer <s.hauer@pengutronix.de>, netdev@vger.kernel.org
Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org,
Paolo Abeni <pabeni@redhat.com>,
io-uring@vger.kernel.org
Subject: Re: [PATCH] net: Do not break out of sk_stream_wait_memory() with TIF_NOTIFY_SIGNAL
Date: Fri, 15 Mar 2024 10:43:12 -0600 [thread overview]
Message-ID: <ed44cb26-7d23-4391-89c5-0e7b59d019f6@kernel.dk> (raw)
In-Reply-To: <20240315100159.3898944-1-s.hauer@pengutronix.de>
On 3/15/24 4:01 AM, Sascha Hauer wrote:
> It can happen that a socket sends the remaining data at close() time.
> With io_uring and KTLS it can happen that sk_stream_wait_memory() bails
> out with -512 (-ERESTARTSYS) because TIF_NOTIFY_SIGNAL is set for the
> current task. This flag has been set in io_req_normal_work_add() by
> calling task_work_add().
>
> This patch replaces signal_pending() with task_sigpending(), thus ignoring
> the TIF_NOTIFY_SIGNAL flag.
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Should probably also flag this for stable, 5.10+ I think as the task
sigpending got backported that far.
--
Jens Axboe
next prev parent reply other threads:[~2024-03-15 16:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 10:01 [PATCH] net: Do not break out of sk_stream_wait_memory() with TIF_NOTIFY_SIGNAL Sascha Hauer
2024-03-15 16:43 ` Jens Axboe [this message]
2024-03-15 17:02 ` Pavel Begunkov
2024-03-18 12:10 ` Sascha Hauer
2024-03-18 13:19 ` Pavel Begunkov
2024-03-19 10:50 ` Sascha Hauer
2024-03-19 13:55 ` Pavel Begunkov
2024-03-19 15:08 ` Sascha Hauer
2024-03-18 12:03 ` Sascha Hauer
2024-03-19 12:30 ` Paolo Abeni
-- strict thread matches above, loose matches on Subject: below --
2023-10-23 12:13 Sascha Hauer
2023-10-24 13:56 ` Paolo Abeni
2023-10-26 7:03 ` Sascha Hauer
2023-10-26 8:49 ` Paolo Abeni
2023-10-27 12:04 ` Sascha Hauer
2023-11-17 10:43 ` Marc Kleine-Budde
2023-12-19 11:00 ` Steffen Trumtrar
2023-12-19 13:13 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed44cb26-7d23-4391-89c5-0e7b59d019f6@kernel.dk \
--to=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).