From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 156B1C43381 for ; Tue, 26 Feb 2019 19:55:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB41521852 for ; Tue, 26 Feb 2019 19:55:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RwYUUlZX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728854AbfBZTzr (ORCPT ); Tue, 26 Feb 2019 14:55:47 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:41115 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728341AbfBZTzr (ORCPT ); Tue, 26 Feb 2019 14:55:47 -0500 Received: by mail-pl1-f193.google.com with SMTP id y5so6733497plk.8; Tue, 26 Feb 2019 11:55:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=COtSbfg3HS0+CPXkgtTURsJN97oXnISz97QBbkPFRb0=; b=RwYUUlZXegfoSbTOKgpKJdIQ3BwIgUGCX/urIyk1nOx/PvSRxG504FSfKrDsMxcbp0 e1HOC/lh3KrFtHgiE5rTB3dAfAYZZpjBTq1mL11XsAUjKH/Ht9Vn1BoA9xD3okHtxUUV nEt//o9/vF2aVub6svjDcdfok1YehHPJ3YkPAdpzlssl/p0PIkRYyNBeHpjn7Cb1cWnt dRjoJSi+pJ/s/quf7euzJhwr0AUnPyy+mhskgXkPGndl6keWUrbtsmTmwxm+U5aMfD4E 5+TAJp6L0x9Y3wO6QWGbb6HZiJHwIdILZCjkTiIVuxTO7XvqTp4UIHDECf4BOYimYwR+ Kfiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=COtSbfg3HS0+CPXkgtTURsJN97oXnISz97QBbkPFRb0=; b=le8amoL+QwOXz10eKM4M/Pc6fL2HM5Ws268ixWR71A9XIpjcSM51n8pBzYlCUQFCwL CeOldLqqRWDVIQ9RNZ0imcuRMiW8Qa++B5lavYmEqnS/VRN6FsCzIlPExIUAI2r/nqzN O/HHm/uDzwS8v17TfyRWnYrl7qJ/MS8tHRjiP7Ap2NSk2FgIn649nfET1Ej5RyhRbkXX 7qCOxDXU5qR/pJ+O12MXcSRD684jAZV437eBoj4YMePTLj/j0yS4sVWHf6QbBX0aV3y3 0mVnHLeipRy31B1gsSWCeeDIntxo06Z/kR8HTPXiw8wAsg0n9116Z5Qnf0uztYwL95qh Pycw== X-Gm-Message-State: AHQUAuYb78EIvSBnIpvdZ+/umFHUoBEIeFQGJwOmkS6+NZy9O2ce8UP6 duWkdi6f8SYr1bIksjg6CcFVzLBt X-Google-Smtp-Source: AHgI3Iach1TEveUGUiRu5Hgf6LsWPUECV2KItfTyBGIEbz739lLoofghYVfU6eWGCJOb4C32dcObLQ== X-Received: by 2002:a17:902:1aa:: with SMTP id b39mr17623752plb.317.1551210946163; Tue, 26 Feb 2019 11:55:46 -0800 (PST) Received: from ?IPv6:2601:282:800:fd80:a09f:958f:bef8:8478? ([2601:282:800:fd80:a09f:958f:bef8:8478]) by smtp.googlemail.com with ESMTPSA id b7sm20179489pfi.36.2019.02.26.11.55.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Feb 2019 11:55:45 -0800 (PST) Subject: Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg() To: Steve Wise , Leon Romanovsky Cc: stephen@networkplumber.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org References: <20190223092615.GM23561@mtr-leonro.mtl.com> <20190223093122.GO23561@mtr-leonro.mtl.com> <7f48fc85-45ab-fe7d-9614-4c5eb50f8401@opengridcomputing.com> From: David Ahern Message-ID: Date: Tue, 26 Feb 2019 12:55:43 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <7f48fc85-45ab-fe7d-9614-4c5eb50f8401@opengridcomputing.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/26/19 10:19 AM, Steve Wise wrote: > >> Will we need this recv_msg if we implement >> extack support? > > I'm not sure how extack works.  Do you know? see devlink/mnlg.c mnlg_socket_open() { ... mnl_socket_setsockopt(nlg->nl, NETLINK_EXT_ACK, &one, sizeof(one)); ... } and mnlg_cb_error() That code under devlink needs to be generic for both tools.