From: Hou Tao <houtao1@huawei.com>
To: Alexei Starovoitov <ast@kernel.org>, Mark Rutland <mark.rutland@arm.com>
Cc: Martin KaFai Lau <kafai@fb.com>, Yonghong Song <yhs@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Song Liu <songliubraving@fb.com>,
"David S . Miller" <davem@davemloft.net>,
John Fastabend <john.fastabend@gmail.com>,
<netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
Zi Shen Lim <zlim.lnx@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Julien Thierry <jthierry@redhat.com>,
Ard Biesheuvel <ardb@kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH bpf-next v3 0/4] bpf, arm64: support more atomic ops
Date: Tue, 15 Feb 2022 12:25:53 +0800 [thread overview]
Message-ID: <f271a3df-e647-3c00-383c-f560ab6e2937@huawei.com> (raw)
In-Reply-To: <20220129220452.194585-1-houtao1@huawei.com>
ping ?
On 1/30/2022 6:04 AM, Hou Tao wrote:
> Hi,
>
> Atomics support in bpf has already been done by "Atomics for eBPF"
> patch series [1], but it only adds support for x86, and this patchset
> adds support for arm64.
>
> Patch #1 & patch #2 are arm64 related. Patch #1 moves the common used
> macro AARCH64_BREAK_FAULT into insn-def.h for insn.h. Patch #2 adds
> necessary encoder helpers for atomic operations.
>
> Patch #3 implements atomic[64]_fetch_add, atomic[64]_[fetch_]{and,or,xor}
> and atomic[64]_{xchg|cmpxchg} for arm64 bpf. Patch #4 changes the type of
> test program from fentry/ to raw_tp/ for atomics test.
>
> For cpus_have_cap(ARM64_HAS_LSE_ATOMICS) case and no-LSE-ATOMICS case,
> ./test_verifier, "./test_progs -t atomic", and "insmod ./test_bpf.ko"
> are exercised and passed correspondingly.
>
> Comments are always welcome.
>
> Regards,
> Tao
>
> [1]: https://lore.kernel.org/bpf/20210114181751.768687-2-jackmanb@google.com/
>
> Change Log:
> v3:
> * split arm64 insn related code into a separated patch (from Mark)
> * update enum name in aarch64_insn_mem_atomic_op (from Mark)
> * consider all cases for aarch64_insn_mem_order_type and
> aarch64_insn_mb_type (from Mark)
> * exercise and pass "insmod ./test_bpf.ko" test (suggested by Daniel)
> * remove aarch64_insn_gen_store_release_ex() and extend
> aarch64_insn_ldst_type instead
> * compile aarch64_insn_gen_atomic_ld_op(), aarch64_insn_gen_cas() and
> emit_lse_atomic() out when CONFIG_ARM64_LSE_ATOMICS is disabled.
>
> v2: https://lore.kernel.org/bpf/20220127075322.675323-1-houtao1@huawei.com/
> * patch #1: use two separated ASSERT_OK() instead of ASSERT_TRUE()
> * add Acked-by tag for both patches
>
> v1: https://lore.kernel.org/bpf/20220121135632.136976-1-houtao1@huawei.com/
>
> Hou Tao (4):
> arm64: move AARCH64_BREAK_FAULT into insn-def.h
> arm64: insn: add encoders for atomic operations
> bpf, arm64: support more atomic operations
> selftests/bpf: use raw_tp program for atomic test
>
> arch/arm64/include/asm/debug-monitors.h | 12 -
> arch/arm64/include/asm/insn-def.h | 14 ++
> arch/arm64/include/asm/insn.h | 80 ++++++-
> arch/arm64/lib/insn.c | 185 +++++++++++++--
> arch/arm64/net/bpf_jit.h | 44 +++-
> arch/arm64/net/bpf_jit_comp.c | 223 ++++++++++++++----
> .../selftests/bpf/prog_tests/atomics.c | 91 ++-----
> tools/testing/selftests/bpf/progs/atomics.c | 28 +--
> 8 files changed, 517 insertions(+), 160 deletions(-)
>
prev parent reply other threads:[~2022-02-15 4:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 22:04 [PATCH bpf-next v3 0/4] bpf, arm64: support more atomic ops Hou Tao
2022-01-29 22:04 ` [PATCH bpf-next v3 1/4] arm64: move AARCH64_BREAK_FAULT into insn-def.h Hou Tao
2022-01-29 22:04 ` [PATCH bpf-next v3 2/4] arm64: insn: add encoders for atomic operations Hou Tao
2022-02-11 14:39 ` Daniel Borkmann
2022-02-15 17:42 ` Will Deacon
2022-02-16 0:21 ` Daniel Borkmann
2022-02-16 17:16 ` Will Deacon
2022-02-17 1:55 ` Hou Tao
2022-01-29 22:04 ` [PATCH bpf-next v3 3/4] bpf, arm64: support more " Hou Tao
2022-01-29 22:04 ` [PATCH bpf-next v3 4/4] selftests/bpf: use raw_tp program for atomic test Hou Tao
2022-02-15 4:25 ` Hou Tao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f271a3df-e647-3c00-383c-f560ab6e2937@huawei.com \
--to=houtao1@huawei.com \
--cc=andrii@kernel.org \
--cc=ardb@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=catalin.marinas@arm.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=jthierry@redhat.com \
--cc=kafai@fb.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=will@kernel.org \
--cc=yhs@fb.com \
--cc=zlim.lnx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).