From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: netdev@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] sh_eth: add sh_eth_cpu_data::no_xdfar flag
Date: Sun, 1 Apr 2018 00:28:20 +0300 [thread overview]
Message-ID: <f2d1b237-fa73-0aab-ef2e-e7cccdfa89f7@cogentembedded.com> (raw)
In-Reply-To: <233e32d1-947b-2377-3d1f-39d5d83bd3f7@cogentembedded.com>
On 04/01/2018 12:22 AM, Sergei Shtylyov wrote:
> The commit 6ded286555c2 ("sh_eth: Fix RX recovery on R-Car in case of RX
> ring underrun") added a check for an bad RDFAR offset in sh_eth_rx(), so
> that the code could work on the R-Car Ether controllers which don't have
> this register (and TDFAR), then the commit 3365711df02 ("sh_eth: WARN on
Oops, only 11 digits! Should have been 3365711df024. :-)
> access to a register not implemented in a particular chip") replaced
> offset 0 with 0xffff. Adding/checking the 'no_xdfar' bit field in the
> 'struct sh_eth_cpu_data' instead results in less object code...
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
[...]
MBR, Sergei
next prev parent reply other threads:[~2018-03-31 21:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-31 21:15 [PATCH 0/2] sh_eth: remove SH_ETH_OFFSET_INVALID abuses Sergei Shtylyov
2018-03-31 21:22 ` [PATCH net-next 1/2] sh_eth: add sh_eth_cpu_data::no_xdfar flag Sergei Shtylyov
2018-03-31 21:28 ` Sergei Shtylyov [this message]
2018-03-31 21:23 ` [PATCH net-next 2/2] sh_eth: kill useless check in __sh_eth_get_regs() Sergei Shtylyov
2018-04-01 18:10 ` [PATCH 0/2] sh_eth: remove SH_ETH_OFFSET_INVALID abuses David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2d1b237-fa73-0aab-ef2e-e7cccdfa89f7@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).