From: Shannon Nelson <snelson@pensando.io>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v4 net-next 13/19] ionic: Add initial ethtool support
Date: Tue, 23 Jul 2019 15:50:52 -0700 [thread overview]
Message-ID: <f2dad663-1ad4-f3b3-76b4-5842e51ec14c@pensando.io> (raw)
In-Reply-To: <20190723.143507.1690183028498872104.davem@davemloft.net>
On 7/23/19 2:35 PM, David Miller wrote:
> From: Shannon Nelson <snelson@pensando.io>
> Date: Mon, 22 Jul 2019 14:40:17 -0700
>
>> +static int ionic_get_link_ksettings(struct net_device *netdev,
>> + struct ethtool_link_ksettings *ks)
>> +{
>> + struct lif *lif = netdev_priv(netdev);
>> + struct ionic_dev *idev = &lif->ionic->idev;
>> + int copper_seen = 0;
> Reverse christmas tree ordering here please.
Sure. Most of these are because I wanted to do the one assignment
first, from which the others are based. I'll rework these to add the
init lines after the declarations. Same in the other files.
sln
>> +static int ionic_set_link_ksettings(struct net_device *netdev,
>> + const struct ethtool_link_ksettings *ks)
>> +{
>> + struct lif *lif = netdev_priv(netdev);
>> + struct ionic *ionic = lif->ionic;
>> + struct ionic_dev *idev = &lif->ionic->idev;
>> + u8 fec_type = PORT_FEC_TYPE_NONE;
>> + u32 req_rs, req_fc;
>> + int err = 0;
> Likewise.
>> +static void ionic_get_pauseparam(struct net_device *netdev,
>> + struct ethtool_pauseparam *pause)
>> +{
>> + struct lif *lif = netdev_priv(netdev);
>> + struct ionic_dev *idev = &lif->ionic->idev;
>> + uint8_t pause_type = idev->port_info->config.pause_type;
> Likewise.
>
>> +static int ionic_set_pauseparam(struct net_device *netdev,
>> + struct ethtool_pauseparam *pause)
>> +{
>> + struct lif *lif = netdev_priv(netdev);
>> + struct ionic *ionic = lif->ionic;
>> + struct ionic_dev *idev = &lif->ionic->idev;
>> + u32 requested_pause;
>> + int err;
> Likewise.
>> +static int ionic_get_module_info(struct net_device *netdev,
>> + struct ethtool_modinfo *modinfo)
>> +
>> +{
>> + struct lif *lif = netdev_priv(netdev);
>> + struct ionic_dev *idev = &lif->ionic->idev;
>> + struct xcvr_status *xcvr;
> Likewise.
>
>> +static int ionic_get_module_eeprom(struct net_device *netdev,
>> + struct ethtool_eeprom *ee,
>> + u8 *data)
>> +{
>> + struct lif *lif = netdev_priv(netdev);
>> + struct ionic_dev *idev = &lif->ionic->idev;
>> + struct xcvr_status *xcvr;
>> + u32 len;
> Likewise.
next prev parent reply other threads:[~2019-07-23 22:50 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 21:40 [PATCH v4 net-next 00/19] Add ionic driver Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 01/19] ionic: Add basic framework for IONIC Network device driver Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 02/19] ionic: Add hardware init and device commands Shannon Nelson
2019-07-23 21:18 ` David Miller
2019-07-23 22:50 ` Shannon Nelson
2019-07-23 23:05 ` David Miller
2019-07-23 23:23 ` Shannon Nelson
2019-07-24 17:49 ` Shannon Nelson
2019-07-24 20:07 ` David Miller
2019-07-23 23:47 ` Saeed Mahameed
2019-07-24 0:25 ` Shannon Nelson
2019-07-24 20:23 ` Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 03/19] ionic: Add port management commands Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 04/19] ionic: Add basic lif support Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 05/19] ionic: Add interrupts and doorbells Shannon Nelson
2019-07-23 21:24 ` David Miller
2019-07-23 22:50 ` Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 06/19] ionic: Add basic adminq support Shannon Nelson
2019-07-23 21:27 ` David Miller
2019-07-23 22:50 ` Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 07/19] ionic: Add adminq action Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 08/19] ionic: Add notifyq support Shannon Nelson
2019-07-24 23:21 ` Saeed Mahameed
2019-07-30 18:35 ` Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 09/19] ionic: Add the basic NDO callbacks for netdev support Shannon Nelson
2019-07-24 23:45 ` Saeed Mahameed
2019-07-30 18:35 ` Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 10/19] ionic: Add management of rx filters Shannon Nelson
2019-07-24 23:52 ` Saeed Mahameed
2019-07-22 21:40 ` [PATCH v4 net-next 11/19] ionic: Add Rx filter and rx_mode ndo support Shannon Nelson
2019-07-23 21:33 ` David Miller
2019-07-23 22:50 ` Shannon Nelson
2019-07-23 23:06 ` David Miller
2019-07-23 23:54 ` Saeed Mahameed
2019-07-24 0:19 ` Shannon Nelson
2019-07-24 0:19 ` Shannon Nelson
2019-07-23 22:51 ` Saeed Mahameed
2019-07-23 23:20 ` Saeed Mahameed
2019-07-24 0:07 ` Shannon Nelson
2019-07-24 21:10 ` Saeed Mahameed
2019-07-22 21:40 ` [PATCH v4 net-next 12/19] ionic: Add async link status check and basic stats Shannon Nelson
2019-07-25 0:04 ` Saeed Mahameed
2019-07-30 18:35 ` Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 13/19] ionic: Add initial ethtool support Shannon Nelson
2019-07-23 21:35 ` David Miller
2019-07-23 22:50 ` Shannon Nelson [this message]
2019-07-25 0:17 ` Saeed Mahameed
2019-07-30 18:57 ` Shannon Nelson
2019-07-25 13:28 ` Andrew Lunn
2019-07-25 13:35 ` Andrew Lunn
2019-07-30 21:51 ` Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 14/19] ionic: Add Tx and Rx handling Shannon Nelson
2019-07-23 21:36 ` David Miller
2019-07-25 23:48 ` Saeed Mahameed
2019-08-09 22:27 ` Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 15/19] ionic: Add netdev-event handling Shannon Nelson
2019-07-25 23:55 ` Saeed Mahameed
2019-07-30 22:53 ` Shannon Nelson
2019-07-30 23:39 ` Stephen Hemminger
2019-07-31 1:10 ` Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 16/19] ionic: Add driver stats Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 17/19] ionic: Add RSS support Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 18/19] ionic: Add coalesce and other features Shannon Nelson
2019-07-23 21:40 ` David Miller
2019-07-26 0:13 ` Saeed Mahameed
2019-08-02 21:48 ` Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 19/19] ionic: Add basic devlink interface Shannon Nelson
2019-07-23 21:40 ` David Miller
2019-07-23 22:50 ` Shannon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2dad663-1ad4-f3b3-76b4-5842e51ec14c@pensando.io \
--to=snelson@pensando.io \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).