From: Alexander H Duyck <alexander.duyck@gmail.com>
To: Hao Lan <lanhao@huawei.com>, davem@davemloft.net, kuba@kernel.org
Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com,
edumazet@google.com, pabeni@redhat.com, richardcochran@gmail.com,
shenjian15@huawei.com, wangjie125@huawei.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net] net: hns3: fix wrong use of rss size during VF rss config
Date: Wed, 11 Jan 2023 08:31:18 -0800 [thread overview]
Message-ID: <f2e3a02cd2a584aa1ed036e90c5c71764e0b8373.camel@gmail.com> (raw)
In-Reply-To: <20230110115359.10163-1-lanhao@huawei.com>
On Tue, 2023-01-10 at 19:53 +0800, Hao Lan wrote:
> From: Jie Wang <wangjie125@huawei.com>
>
> Currently, it used old rss size to get current tc mode. As a result, the
> rss size is updated, but the tc mode is still configured based on the old
> rss size.
>
> So this patch fixes it by using the new rss size in both process.
>
> Fixes: 93969dc14fcd ("net: hns3: refactor VF rss init APIs with new common rss init APIs")
> Signed-off-by: Jie Wang <wangjie125@huawei.com>
> Signed-off-by: Hao Lan <lanhao@huawei.com>
> ---
> drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
> index 081bd2c3f289..e84e5be8e59e 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
> @@ -3130,7 +3130,7 @@ static int hclgevf_set_channels(struct hnae3_handle *handle, u32 new_tqps_num,
>
> hclgevf_update_rss_size(handle, new_tqps_num);
>
> - hclge_comm_get_rss_tc_info(cur_rss_size, hdev->hw_tc_map,
> + hclge_comm_get_rss_tc_info(kinfo->rss_size, hdev->hw_tc_map,
> tc_offset, tc_valid, tc_size);
> ret = hclge_comm_set_rss_tc_mode(&hdev->hw.hw, tc_offset,
> tc_valid, tc_size);
I can see how this was confused. It isn't really clear that handle is
being used to update the kinfo->rss_size value. Maybe think about
adding a comment to prevent someone from reverting this without
realizing that? It might also be useful to do a follow-on patch for
net-next that renames cur_rss_size to orig_rss_size to make it more
obvious that the value is changing.
Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
next prev parent reply other threads:[~2023-01-11 16:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 11:53 [PATCH net] net: hns3: fix wrong use of rss size during VF rss config Hao Lan
2023-01-11 16:31 ` Alexander H Duyck [this message]
2023-01-12 2:56 ` Hao Lan
2023-01-12 15:36 ` Alexander Duyck
2023-01-12 4:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2e3a02cd2a584aa1ed036e90c5c71764e0b8373.camel@gmail.com \
--to=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=lanhao@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=salil.mehta@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangjie125@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).