From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C2B0C4363A for ; Wed, 21 Oct 2020 10:54:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 328A02098B for ; Wed, 21 Oct 2020 10:54:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=tessares-net.20150623.gappssmtp.com header.i=@tessares-net.20150623.gappssmtp.com header.b="BAx9KIFO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439134AbgJUKyQ (ORCPT ); Wed, 21 Oct 2020 06:54:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390849AbgJUKyQ (ORCPT ); Wed, 21 Oct 2020 06:54:16 -0400 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63EC6C0613CE for ; Wed, 21 Oct 2020 03:54:14 -0700 (PDT) Received: by mail-ej1-x643.google.com with SMTP id t25so2489578ejd.13 for ; Wed, 21 Oct 2020 03:54:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tessares-net.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=HfW34gsf7g1g/Ty9vqXj5/WoQ9OW8/EuoLSIxqDJrBw=; b=BAx9KIFOKJ3zL+agOvEbRnKvR+kquRN6xghHcsGlLod/LB+2PUFRGIpt+fyQdMkhCE cA+JP/1VPJ4zra/4AP6f7d0uYLDDcVi221bFKH0jTUfcC57PvDbxNcXxA8uSdrRmSq6k BYGIqEFRzFegZoEklykvXGbeNygK1/gesH4fa+e3ZOYPXMgH7nU81/AOooK5bxYnr5YI pIdygi6DVhdGpGpkvtLOBZLBpdGgXhSX5bg/5Hp8q9N6alD9ARzn/wrP5mW/tw/UWMk4 DyEVLWKBakdCha0x6tMdSQLep5J7KAgUluUoIwvhyGpYBcQcQm/7o2fn+vrsFbizwA6O jDOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HfW34gsf7g1g/Ty9vqXj5/WoQ9OW8/EuoLSIxqDJrBw=; b=nUyn3CmW9PnruMpidKE2GFfyroVgJsE3YepPFnInAeNIiIQTJCmt6Qu30CYEVCyfMa aTGdMJ1XWpHEB0JEIEXc30feiuGjCwcwgQmNjmsjIUCq5Yjp0IPM2AP7LwVAgGLEPERT sb3e+jW3xcHuEVJXKixUG/rNmQ4jp20oGi1+WN7MoOdP44yjKuIKngcVveSj+zOklbCH VC6s94ZZLL/SIWl6J19PK15UZ0tYT2iJQ56prFG7XAzt311bIV1w+T/VsDlGCJzCG444 lfXDyL85VOw4TQpQHJNEvhxWPA+Jdb07Cw6EQBGZf9FAM1pmk6fWxqCtlQKW+42g/shM 7s8w== X-Gm-Message-State: AOAM532FgKWtCCRMZIxtxYyLqhtJ8+KWFo1+52LvtuDt2thXRbNGddCW 5jDB43zfZm/0/i/2T1NhFivrqotAf6fOq98D X-Google-Smtp-Source: ABdhPJwLxqM2i3gZnaB2H4ECV6ww6BmzkBlev8VYw0Ieio7hGbJv6GHRneJUXwOMJAAz+uHYD1JHmw== X-Received: by 2002:a17:906:b1a:: with SMTP id u26mr2796253ejg.23.1603277653004; Wed, 21 Oct 2020 03:54:13 -0700 (PDT) Received: from tsr-lap-08.nix.tessares.net ([2a02:578:85b0:e00:9bd7:d012:64eb:ce81]) by smtp.gmail.com with ESMTPSA id g18sm2073166eje.12.2020.10.21.03.54.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Oct 2020 03:54:12 -0700 (PDT) Subject: Re: [PATCH] mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it To: Geert Uytterhoeven Cc: Jakub Kicinski , Mat Martineau , "David S . Miller" , Florian Westphal , netdev , mptcp@lists.01.org, Linux Kernel Mailing List References: <20201020073839.29226-1-geert@linux-m68k.org> <5dddd3fe-86d7-d07f-dbc9-51b89c7c8173@tessares.net> <20201020205647.20ab7009@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <619601b2-40c1-9257-ef2a-2c667361aa75@tessares.net> From: Matthieu Baerts Message-ID: Date: Wed, 21 Oct 2020 12:54:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Geert, On 21/10/2020 11:52, Geert Uytterhoeven wrote: > Hi Matthieu, > > On Wed, Oct 21, 2020 at 11:47 AM Matthieu Baerts > wrote: >> On 21/10/2020 11:43, Geert Uytterhoeven wrote: >>> On Wed, Oct 21, 2020 at 5:56 AM Jakub Kicinski wrote: >>>> On Tue, 20 Oct 2020 11:26:34 +0200 Matthieu Baerts wrote: >>>>> On 20/10/2020 09:38, Geert Uytterhoeven wrote: >>>>>> MPTCP_IPV6 selects IPV6, thus enabling an optional feature the user may >>>>>> not want to enable. Fix this by making MPTCP_IPV6 depend on IPV6, like >>>>>> is done for all other IPv6 features. >>>>> >>>>> Here again, the intension was to select IPv6 from MPTCP but I understand >>>>> the issue: if we enable MPTCP, we will select IPV6 as well by default. >>>>> Maybe not what we want on some embedded devices with very limited memory >>>>> where IPV6 is already off. We should instead enable MPTCP_IPV6 only if >>>>> IPV6=y. LGTM then! >>>>> >>>>> Reviewed-by: Matthieu Baerts >>>> >>>> Applied, thanks! >>> >>> My apologies, this fails for the CONFIG_IPV6=m and CONFIG_MPTCP=y >>> case: >> >> Good point, MPTCP cannot be compiled as a module (like TCP). It should >> then depends on IPV6=y. I thought it would be the case. >> >> Do you want me to send a patch or do you already have one? > > I don't have a patch yet, so feel free to send one. Just did: https://lore.kernel.org/netdev/20201021105154.628257-1-matthieu.baerts@tessares.net/ Groetjes, Matt -- Tessares | Belgium | Hybrid Access Solutions www.tessares.net