From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A876BC433E1 for ; Mon, 17 Aug 2020 18:49:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82C5A204EC for ; Mon, 17 Aug 2020 18:49:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="V1+OhIqV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403873AbgHQStn (ORCPT ); Mon, 17 Aug 2020 14:49:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389560AbgHQSth (ORCPT ); Mon, 17 Aug 2020 14:49:37 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97D33C061389 for ; Mon, 17 Aug 2020 11:49:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=Ze63YpEZxuugDTu1ATLuAPoRJArgFsDzypuy3riKUtg=; b=V1+OhIqVUKSytBNJQxcnwtTfsX iSASMinzheDJl7mOUCCCNeDU6dO2Rrgb9snkCQZeKYgV7c3DwzQuFXvER4FfDABreMzSUXIWRF/UY aMW5eKYtJPtD/ATOSxI7tFia8VSq33ZmD4JHIuZEw1hahu+qM/brwJJOLyuoz+3dhT0DaxC74O7xI OF0HHRF+Bd0CvW+WlkD2KiNh2DfEqfKehVY4sCUeJFtMgvBB20gUO6xJ2yZ0GFhbjABSRqIMohKXE GgKgquFTMxXdBbqUUmZRkDtSHDbX5f9tIJvjjqtvTpA9prjPkZgClxsAhju3t0DlCQFjrYOhIuLxN mcj/wGxQ==; Received: from [2601:1c0:6280:3f0::19c2] by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7kC0-00073X-E4; Mon, 17 Aug 2020 18:49:13 +0000 Subject: Re: [PATCH net] tipc: not enable tipc when ipv6 works as a module To: Cong Wang , Xin Long Cc: network dev , David Miller , Jon Maloy , Ying Xue , tipc-discussion@lists.sourceforge.net References: From: Randy Dunlap Message-ID: Date: Mon, 17 Aug 2020 11:49:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 8/17/20 11:31 AM, Cong Wang wrote: > On Sun, Aug 16, 2020 at 11:37 PM Xin Long wrote: >> >> On Mon, Aug 17, 2020 at 2:29 AM Cong Wang wrote: >>> >>> Or put it into struct ipv6_stub? >> Hi Cong, >> >> That could be one way. We may do it when this new function becomes more common. >> By now, I think it's okay to make TIPC depend on IPV6 || IPV6=n. > > I am not a fan of IPV6=m, but disallowing it for one symbol seems > too harsh. Hi, Maybe I'm not following you, but this doesn't disallow IPV6=m. It just restricts how TIPC can be built, so that TIPC=y and IPV6=m cannot happen together, which causes a build error. -- ~Randy