From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE122C54EE9 for ; Fri, 16 Sep 2022 15:21:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231641AbiIPPVH (ORCPT ); Fri, 16 Sep 2022 11:21:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231562AbiIPPVE (ORCPT ); Fri, 16 Sep 2022 11:21:04 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFDB082FA2; Fri, 16 Sep 2022 08:21:01 -0700 (PDT) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28GD6xEl018195; Fri, 16 Sep 2022 15:20:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=wBvc5kjqSvGVlMipQAv6v4gLaFz+BavyO2mTc58+5tg=; b=L3MZra1DCquB7AMvqvzOCBtHywAcHq/FnPAFQWo7MkoDYxThaVR1i8b/FPPq5a+H25st 58RkEocgYziqLrlqkRJY/WA42EeYK//9yKBzv2G1RzrvDtjSCjvGh5tuX5MQK4fUl51v tShMHyoufHbII7p0oXU/Qk2RWi+nfYhXuYqeauWdwN9I2rhUnzDZckJqe6TAA1Hjxsud /Ps2PI/KsWv03+16CVUWbudbO/Uykj5iUNakBsNFaoUprPRYdS0Ab34cR7kkaU0S/yWn sPB/NTQdycbawnIpp2Y3NuAsjK0HKDmOCqZkHeZnhwym7vA8Da/cBYSLKL/66+uTHmmt XA== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3jm8xmunbt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 Sep 2022 15:20:47 +0000 Received: from pps.filterd (NALASPPMTA03.qualcomm.com [127.0.0.1]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 28GFFnGk008145; Fri, 16 Sep 2022 15:20:46 GMT Received: from pps.reinject (localhost [127.0.0.1]) by NALASPPMTA03.qualcomm.com (PPS) with ESMTPS id 3jkyc2dy25-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 Sep 2022 15:20:46 +0000 Received: from NALASPPMTA03.qualcomm.com (NALASPPMTA03.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 28GF4o0l026041; Fri, 16 Sep 2022 15:20:45 GMT Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (PPS) with ESMTPS id 28GFKjZP013121 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 Sep 2022 15:20:45 +0000 Received: from [10.110.7.80] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Fri, 16 Sep 2022 08:20:43 -0700 Message-ID: Date: Fri, 16 Sep 2022 08:20:42 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 3/4] slimbus: qcom-ngd-ctrl: Make QMI message rules const To: Srinivas Kandagatla , Alex Elder , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Mathieu Poirier , Kalle Valo , Andy Gross , Bjorn Andersson , Konrad Dybcio CC: , , , , References: <20220912232526.27427-1-quic_jjohnson@quicinc.com> <20220912232526.27427-2-quic_jjohnson@quicinc.com> <20220912232526.27427-3-quic_jjohnson@quicinc.com> <20220912232526.27427-4-quic_jjohnson@quicinc.com> <65f11ed1-f09f-e0a2-91f5-891394160c96@linaro.org> Content-Language: en-US From: Jeff Johnson In-Reply-To: <65f11ed1-f09f-e0a2-91f5-891394160c96@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: N1YML4LhMNVhIb3BzHEaZ0fgMRS9KksY X-Proofpoint-ORIG-GUID: N1YML4LhMNVhIb3BzHEaZ0fgMRS9KksY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-16_09,2022-09-16_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 suspectscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 mlxlogscore=723 priorityscore=1501 clxscore=1015 impostorscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2209160112 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 9/16/2022 6:06 AM, Srinivas Kandagatla wrote: > > > On 13/09/2022 00:25, Jeff Johnson wrote: >> Commit ff6d365898d ("soc: qcom: qmi: use con > > SHA ID should be at least 12 chars long. > > Same comment for all the patches in the series. > > > st for struct >> qmi_elem_info") allows QMI message encoding/decoding rules to be >> const, so do that for qcom-ngd-ctrl. >> >> Signed-off-by: Jeff Johnson > > Other than that it LGTM, > Once fixed: > > Acked-by: Srinivas Kandagatla > > > --srini that was corrected in v2. thx for the ack