From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80708C43603 for ; Fri, 20 Dec 2019 20:24:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5C15F206D8 for ; Fri, 20 Dec 2019 20:24:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727564AbfLTUYd convert rfc822-to-8bit (ORCPT ); Fri, 20 Dec 2019 15:24:33 -0500 Received: from mga02.intel.com ([134.134.136.20]:40091 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727402AbfLTUYd (ORCPT ); Fri, 20 Dec 2019 15:24:33 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Dec 2019 12:24:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,337,1571727600"; d="scan'208";a="267612649" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 20 Dec 2019 12:24:32 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 20 Dec 2019 12:24:31 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 20 Dec 2019 12:24:31 -0800 Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmsx602.amr.corp.intel.com ([10.18.126.82]) with mapi id 15.01.1713.004; Fri, 20 Dec 2019 12:24:31 -0800 From: "Bowers, AndrewX" To: "netdev@vger.kernel.org" CC: "intel-wired-lan@lists.osuosl.org" Subject: RE: [Intel-wired-lan] [PATCH net-next 2/2] drivers: net: ice: Removing hung_queue variable to use txqueue function parameter Thread-Topic: [Intel-wired-lan] [PATCH net-next 2/2] drivers: net: ice: Removing hung_queue variable to use txqueue function parameter Thread-Index: AQHVtgThBxGKLI4+qkutpf6gFctWIKfDet6A Date: Fri, 20 Dec 2019 20:24:31 +0000 Message-ID: References: <20191218183845.20038-1-jcfaracco@gmail.com> <20191218183845.20038-3-jcfaracco@gmail.com> In-Reply-To: <20191218183845.20038-3-jcfaracco@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODdjNjQ2MTctMDJlZS00YTczLWE0NDQtZjA3MTAxNzZkMmE5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYWpGWW5iNFBiQjVKWEFPeDQ2bmJoZjkrdzV0NFRnUlRrdytTZ2RmOXo3TXJpV2xLdkVENUt2cmlSQWp4b2FIcSJ9 dlp-reaction: no-action dlp-version: 11.0.400.15 x-originating-ip: [10.22.254.132] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > -----Original Message----- > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On > Behalf Of Julio Faracco > Sent: Wednesday, December 18, 2019 10:39 AM > To: netdev@vger.kernel.org > Cc: intel-wired-lan@lists.osuosl.org; davem@davemloft.net > Subject: [Intel-wired-lan] [PATCH net-next 2/2] drivers: net: ice: Removing > hung_queue variable to use txqueue function parameter > > The scope of function .ndo_tx_timeout was changed to include the hang > queue when a TX timeout event occurs. See commit 0290bd291cc0 > ("netdev: pass the stuck queue to the timeout handler") for more details. > Now, drivers don't need to identify which queue is stopped. > Drivers can simply use the queue index provided bt dev_watchdog and > execute all actions needed to restore network traffic. This commit do some > cleanups into Intel ice driver to remove a redundant loop to find stopped > queue. > > Signed-off-by: Julio Faracco > --- > drivers/net/ethernet/intel/ice/ice_main.c | 41 ++++++----------------- > 1 file changed, 11 insertions(+), 30 deletions(-) Tested-by: Andrew Bowers