From: David Ahern <dsahern@gmail.com>
To: Ido Schimmel <idosch@nvidia.com>, netdev@vger.kernel.org
Cc: stephen@networkplumber.org, razor@blackwall.org,
netdev@kapio-technology.com, mlxsw@nvidia.com
Subject: Re: [PATCH iproute2-next] iplink_bridge: Add no_linklocal_learn option support
Date: Mon, 3 Oct 2022 08:40:47 -0600 [thread overview]
Message-ID: <f7251b13-dbf2-f86c-6c2a-2c037b208017@gmail.com> (raw)
In-Reply-To: <20221001143551.1291987-1-idosch@nvidia.com>
On 10/1/22 8:35 AM, Ido Schimmel wrote:
> @@ -159,6 +160,18 @@ static int bridge_parse_opt(struct link_util *lu, int argc, char **argv,
> if (len < 0)
> return -1;
> addattr_l(n, 1024, IFLA_BR_GROUP_ADDR, llabuf, len);
> + } else if (matches(*argv, "no_linklocal_learn") == 0) {
changed matches to strcmp and applied to iproute2-next
> + __u32 no_ll_learn_bit = 1 << BR_BOOLOPT_NO_LL_LEARN;
> + __u8 no_ll_learn;
> +
> + NEXT_ARG();
> + if (get_u8(&no_ll_learn, *argv, 0))
> + invarg("invalid no_linklocal_learn", *argv);
> + bm.optmask |= 1 << BR_BOOLOPT_NO_LL_LEARN;
> + if (no_ll_learn)
> + bm.optval |= no_ll_learn_bit;
> + else
> + bm.optval &= ~no_ll_learn_bit;
> } else if (matches(*argv, "fdb_flush") == 0) {
> addattr(n, 1024, IFLA_BR_FDB_FLUSH);
> } else if (matches(*argv, "vlan_default_pvid") == 0) {
prev parent reply other threads:[~2022-10-03 14:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 14:35 [PATCH iproute2-next] iplink_bridge: Add no_linklocal_learn option support Ido Schimmel
2022-10-03 14:40 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7251b13-dbf2-f86c-6c2a-2c037b208017@gmail.com \
--to=dsahern@gmail.com \
--cc=idosch@nvidia.com \
--cc=mlxsw@nvidia.com \
--cc=netdev@kapio-technology.com \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).