From: "Jürgen Groß" <jgross@suse.com>
To: Denis Kirjanov <kda@linux-powerpc.org>, netdev@vger.kernel.org
Cc: ilias.apalodimas@linaro.org, wei.liu@kernel.org, paul@xen.org
Subject: Re: [PATCH net-next v4] xen networking: add basic XDP support for xen-netfront
Date: Wed, 18 Mar 2020 12:16:25 +0100 [thread overview]
Message-ID: <f75365c7-a3ca-cf12-b2fc-e48652071795@suse.com> (raw)
In-Reply-To: <1584364176-23346-1-git-send-email-kda@linux-powerpc.org>
On 16.03.20 14:09, Denis Kirjanov wrote:
> The patch adds a basic XDP processing to xen-netfront driver.
>
> We ran an XDP program for an RX response received from netback
> driver. Also we request xen-netback to adjust data offset for
> bpf_xdp_adjust_head() header space for custom headers.
This is in no way a "verbose patch descriprion".
I'm missing:
- Why are you doing this. "Add XDP support" is not enough, for such
a change I'd like to see some performance numbers to get an idea
of the improvement to expect, or which additional functionality
for the user is available.
- A short description for me as a Xen maintainer with only basic
networking know-how, what XDP programs are about (a link to some
more detailed doc is enough, of course) and how the interface
is working (especially for switching between XDP mode and normal
SKB processing).
- A proper description of the netfront/netback communication when
enabling or disabling XDP mode (who is doing what, is silencing
of the virtual adapter required, ...).
- Reasoning why the suggested changes of frontend and backend state
are no problem for special cases like hot-remove of an interface or
live migration or suspend of the guest.
Finally I'd like to ask you to split up the patch into a netfront and
a netback one.
Juergen
next prev parent reply other threads:[~2020-03-18 11:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 13:09 [PATCH net-next v4] xen networking: add basic XDP support for xen-netfront Denis Kirjanov
2020-03-16 15:44 ` Jesper Dangaard Brouer
2020-03-18 12:31 ` Denis Kirjanov
2020-03-16 15:52 ` Jesper Dangaard Brouer
2020-03-18 12:30 ` Denis Kirjanov
2020-03-18 10:27 ` Paul Durrant
2020-03-18 11:16 ` Jürgen Groß [this message]
2020-03-18 12:50 ` Denis Kirjanov
2020-03-18 13:11 ` Jürgen Groß
2020-03-23 10:15 ` Denis Kirjanov
2020-03-23 10:27 ` Jürgen Groß
2020-03-23 10:49 ` Denis Kirjanov
2020-03-23 11:00 ` Jürgen Groß
2020-03-30 12:16 ` Denis Kirjanov
2020-03-30 12:55 ` Jürgen Groß
2020-03-30 13:09 ` Denis Kirjanov
2020-03-30 13:13 ` Jürgen Groß
2020-03-30 13:18 ` Denis Kirjanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f75365c7-a3ca-cf12-b2fc-e48652071795@suse.com \
--to=jgross@suse.com \
--cc=ilias.apalodimas@linaro.org \
--cc=kda@linux-powerpc.org \
--cc=netdev@vger.kernel.org \
--cc=paul@xen.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).