From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED406C10F00 for ; Fri, 22 Feb 2019 16:20:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB3D62070D for ; Fri, 22 Feb 2019 16:20:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cumulusnetworks.com header.i=@cumulusnetworks.com header.b="KcjX22jY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726743AbfBVQUG (ORCPT ); Fri, 22 Feb 2019 11:20:06 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:55980 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725832AbfBVQUF (ORCPT ); Fri, 22 Feb 2019 11:20:05 -0500 Received: by mail-wm1-f68.google.com with SMTP id q187so2486246wme.5 for ; Fri, 22 Feb 2019 08:20:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1X+2YgoXTAyBlIJgma5KiZIdDCsrXZFX9JNuG5zGnuU=; b=KcjX22jY4dHXQKALixbTx17S0a3JWoFGkov1y6GGrTcW1/ac4PhuK12bXTuUfBLKLN dEBEEfrulWLxheBMEDXf04XiGbgTn+JPUDlyZEW+KwDLw/BAEnX1ZYqL5cW9Qm4PnlCu +rUrqty3eIF+02tuwwGrYdpExTDaRxmAkF9KM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1X+2YgoXTAyBlIJgma5KiZIdDCsrXZFX9JNuG5zGnuU=; b=kCMrPn3VcNih1AIg/NyX+4ChEx95iPtB7h2G6qCCiHlerF5JvhM1YgR46WiyoEzCGD h8KHM8JwnDqmj1M9PT9quMkpiR/551ufKLcIj6Fu6RebLzO348RFm0Ke2efhzAOl0UD0 UUJ5InyX/nZUaWjmYPHtWc8jc4WFcJnA/sSjMApp1tIDpVKpL/xdBmP5Eh26d+muZK0M LpmgjAofM4E+plDoFYo6An9dWWPYqZ6/E4shm6pZxcZgEuWGo/hAKKd5x4oS9BFIIHkn ep5PIeu4zk44V2sX1pjjPMyG/td5pM8D11G+Qm9z0Wtgmiiv/7r4zIxUUvIIX13chcqo lqtg== X-Gm-Message-State: AHQUAubImz+Ynw+v1o9Fr7InQ8JahhNqAU9CQ2oaJ8zlYg2I8t7PkgVl voOPa5Lwg3nYh54vHxQh/fYSkg== X-Google-Smtp-Source: AHgI3IYNVOja26GioLHHsVN0zPWumvuPKqYurhJ1rYzD66bdX58IlDozS55hfYHIyDp1mLGvoMI1kw== X-Received: by 2002:a1c:7fcb:: with SMTP id a194mr3054502wmd.51.1550852403250; Fri, 22 Feb 2019 08:20:03 -0800 (PST) Received: from [192.168.0.107] (79-100-158-105.ip.btc-net.bg. [79.100.158.105]) by smtp.gmail.com with ESMTPSA id l18sm2037770wrv.20.2019.02.22.08.20.01 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 22 Feb 2019 08:20:02 -0800 (PST) Subject: Re: [PATCH net] Revert "bridge: do not add port to router list when receives query with source 0.0.0.0" To: Hangbin Liu , netdev@vger.kernel.org Cc: roopa@cumulusnetworks.com, bridge@lists.linux-foundation.org, davem@davemloft.net, yinxu@redhat.com, Greg Kroah-Hartman , stable@vger.kernel.org, Sebastian Gottschall , =?UTF-8?Q?Linus_L=c3=bcssing?= References: <20190222132232.24123-1-liuhangbin@gmail.com> From: Nikolay Aleksandrov Message-ID: Date: Fri, 22 Feb 2019 18:20:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190222132232.24123-1-liuhangbin@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 22/02/2019 15:22, Hangbin Liu wrote: > This reverts commit 5a2de63fd1a5 ("bridge: do not add port to router list > when receives query with source 0.0.0.0") and commit 0fe5119e267f ("net: > bridge: remove ipv6 zero address check in mcast queries") > > The reason is RFC 4541 is not a standard but suggestive. Currently we > will elect 0.0.0.0 as Querier if there is no ip address configured on > bridge. If we do not add the port which recives query with source > 0.0.0.0 to router list, the IGMP reports will not be about to forward > to Querier, IGMP data will also not be able to forward to dest. > > As Nikolay suggested, revert this change first and add a boolopt api > to disable none-zero election in future if needed. > > Reported-by: Linus Lüssing > Reported-by: Sebastian Gottschall > Fixes: 5a2de63fd1a5 ("bridge: do not add port to router list when receives query with source 0.0.0.0") > Fixes: 0fe5119e267f ("net: bridge: remove ipv6 zero address check in mcast queries") > Signed-off-by: Hangbin Liu > --- > net/bridge/br_multicast.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > Thank you. Unfortunately we made a mistake and have to fix compatibility with the current bridges. As noted in the commit message if this is needed it can be added as optional behaviour with default off so we don't break any setups. Acked-by: Nikolay Aleksandrov