From: David Ahern <dsahern@kernel.org>
To: Arun Ajith S <aajith@arista.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org,
bagasdotme@gmail.com, yoshfuji@linux-ipv6.org, kuba@kernel.org,
pabeni@redhat.com, prestwoj@gmail.com, corbet@lwn.net,
justin.iurman@uliege.be, edumazet@google.com, shuah@kernel.org,
gilligan@arista.com, noureddine@arista.com, gk@arista.com
Subject: Re: [PATCH net v3] net/ipv6: Expand and rename accept_unsolicited_na to accept_untracked_na
Date: Mon, 30 May 2022 10:22:12 -0600 [thread overview]
Message-ID: <f79c9fc6-9635-50a6-8b71-f280bf2a192b@kernel.org> (raw)
In-Reply-To: <20220530101414.65439-1-aajith@arista.com>
On 5/30/22 4:14 AM, Arun Ajith S wrote:
> RFC 9131 changes default behaviour of handling RX of NA messages when the
> corresponding entry is absent in the neighbour cache. The current
> implementation is limited to accept just unsolicited NAs. However, the
> RFC is more generic where it also accepts solicited NAs. Both types
> should result in adding a STALE entry for this case.
>
> Expand accept_untracked_na behaviour to also accept solicited NAs to
> be compliant with the RFC and rename the sysctl knob to
> accept_untracked_na.
>
> Fixes: f9a2fb73318e ("net/ipv6: Introduce accept_unsolicited_na knob to implement router-side changes for RFC9131")
> Signed-off-by: Arun Ajith S <aajith@arista.com>
> ---
> This change updates the accept_unsolicited_na feature that merged to net-next
> for v5.19 to be better compliant with the RFC. It also involves renaming the sysctl
> knob to accept_untracked_na before shipping in a release.
>
> Note that the behaviour table has been modifed in the code comments,
> but dropped from the Documentation. This is because the table
> documents behaviour that is not unique to the knob, and it is more
> relevant to understanding the code. The documentation has been updated
> to be unambiguous even without the table.
>
> v2:
> 1. Changed commit message and subject as suggested.
> 2. Added Fixes tag.
> 3. Used en-uk spellings consistently.
> 4. Added a couple of missing comments.
> 5. Refactored patch to be smaller by avoiding early return.
> 6. Made the documentation more clearer.
>
> v3:
> 1. Fixed build issue. (Verified make defconfig && make && make htmldocs SPHINXDIRS=networking)
>
> Documentation/networking/ip-sysctl.rst | 23 ++++------
> include/linux/ipv6.h | 2 +-
> include/uapi/linux/ipv6.h | 2 +-
> net/ipv6/addrconf.c | 6 +--
> net/ipv6/ndisc.c | 42 +++++++++++--------
> .../net/ndisc_unsolicited_na_test.sh | 23 +++++-----
> 6 files changed, 50 insertions(+), 48 deletions(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2022-05-30 16:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-30 10:14 [PATCH net v3] net/ipv6: Expand and rename accept_unsolicited_na to accept_untracked_na Arun Ajith S
2022-05-30 16:22 ` David Ahern [this message]
2022-05-31 10:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f79c9fc6-9635-50a6-8b71-f280bf2a192b@kernel.org \
--to=dsahern@kernel.org \
--cc=aajith@arista.com \
--cc=bagasdotme@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gilligan@arista.com \
--cc=gk@arista.com \
--cc=justin.iurman@uliege.be \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noureddine@arista.com \
--cc=pabeni@redhat.com \
--cc=prestwoj@gmail.com \
--cc=shuah@kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).