From: Faiz Abbas <faiz_abbas@ti.com>
To: Dan Murphy <dmurphy@ti.com>, <wg@grandegger.com>,
<mkl@pengutronix.de>, <davem@davemloft.net>
Cc: <linux-can@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v12 5/5] can: m_can: Fix checkpatch issues on existing code
Date: Tue, 25 Jun 2019 14:54:53 +0530 [thread overview]
Message-ID: <f7f61ccb-f6e9-1e74-a716-96f246944b64@ti.com> (raw)
In-Reply-To: <20190509161109.10499-5-dmurphy@ti.com>
Hi,
On 09/05/19 9:41 PM, Dan Murphy wrote:
> Fix checkpatch issues found during the m_can framework creation.
> The code the issues were in, was in untouched code and these
> changes should be done separately as to not be confused with the
> framework changes.
>
> Fix these 3 check issues:
> CHECK: Unnecessary parentheses around 'cdev->can.state != CAN_STATE_ERROR_WARNING'
> if (psr & PSR_EW &&
> (cdev->can.state != CAN_STATE_ERROR_WARNING)) {
>
> CHECK: Unnecessary parentheses around 'cdev->can.state != CAN_STATE_ERROR_PASSIVE'
> if ((psr & PSR_EP) &&
> (cdev->can.state != CAN_STATE_ERROR_PASSIVE)) {
>
> CHECK: Unnecessary parentheses around 'cdev->can.state != CAN_STATE_BUS_OFF'
> if ((psr & PSR_BO) &&
> (cdev->can.state != CAN_STATE_BUS_OFF)) {
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
Acked-by: Faiz Abbas <faiz_abbas@ti.com>
Thanks,
Faiz
next prev parent reply other threads:[~2019-06-25 9:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 16:11 [PATCH v12 1/5] can: m_can: Create a m_can platform framework Dan Murphy
2019-05-09 16:11 ` [PATCH v12 2/5] can: m_can: Rename m_can_priv to m_can_classdev Dan Murphy
2019-06-25 9:23 ` Faiz Abbas
2019-05-09 16:11 ` [PATCH v12 3/5] dt-bindings: can: tcan4x5x: Add DT bindings for TCAN4x5X driver Dan Murphy
2019-08-16 9:38 ` Marc Kleine-Budde
2019-08-22 14:20 ` Dan Murphy
2019-08-22 15:46 ` Marc Kleine-Budde
2019-08-22 15:58 ` Dan Murphy
2019-05-09 16:11 ` [PATCH v12 4/5] can: tcan4x5x: Add tcan4x5x driver to the kernel Dan Murphy
2019-05-09 16:11 ` [PATCH v12 5/5] can: m_can: Fix checkpatch issues on existing code Dan Murphy
2019-06-25 9:24 ` Faiz Abbas [this message]
2019-05-15 20:54 ` [PATCH v12 1/5] can: m_can: Create a m_can platform framework Dan Murphy
2019-05-31 11:51 ` Dan Murphy
2019-06-06 13:16 ` Dan Murphy
2019-06-10 16:35 ` Dan Murphy
2019-06-17 15:09 ` Dan Murphy
2019-07-10 12:08 ` Dan Murphy
2019-07-23 15:14 ` Dan Murphy
2019-07-24 6:47 ` Greg KH
2019-07-24 15:36 ` Dan Murphy
2019-07-25 6:28 ` Greg KH
2019-07-25 7:09 ` Marc Kleine-Budde
2019-07-16 18:23 ` Dan Murphy
2019-05-23 20:18 ` Dan Murphy
2019-06-25 9:22 ` Faiz Abbas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7f61ccb-f6e9-1e74-a716-96f246944b64@ti.com \
--to=faiz_abbas@ti.com \
--cc=davem@davemloft.net \
--cc=dmurphy@ti.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).