From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EADC3C4332F for ; Wed, 16 Nov 2022 21:00:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233840AbiKPVAx (ORCPT ); Wed, 16 Nov 2022 16:00:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233413AbiKPVA3 (ORCPT ); Wed, 16 Nov 2022 16:00:29 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7A326EB7C for ; Wed, 16 Nov 2022 12:56:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668632173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DTuWmJjejdv+SurQA0gLdWcYF6qf7avEj+rPkV8wTt0=; b=dkcIepzZDPh/hCVkvoVCooD4qSh9R4CTnJ8kmfwelHB3P1JTyyPMu3sekG9wcNZLrq1uTO hNgc259pUAbszjpxfjvEi1sgUZsKYXRnZ8W51ACGwg5oK6pvlgKpdwhRzaa/m/WrYOxaj7 R4gNTCBb6cSB/+y3mfw9pQAjtWd2zWY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-569-WjUVxafTOAauFqhryKEtQQ-1; Wed, 16 Nov 2022 15:56:07 -0500 X-MC-Unique: WjUVxafTOAauFqhryKEtQQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CC41738041C2; Wed, 16 Nov 2022 20:56:06 +0000 (UTC) Received: from RHTPC1VM0NT (unknown [10.22.19.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3B96E1121314; Wed, 16 Nov 2022 20:56:06 +0000 (UTC) From: Aaron Conole To: Xin Long Cc: network dev , dev@openvswitch.org, davem@davemloft.net, kuba@kernel.org, Eric Dumazet , Paolo Abeni , Pravin B Shelar , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Pablo Neira Ayuso , Florian Westphal , Marcelo Ricardo Leitner , Davide Caratti , Eelco Chaudron Subject: Re: [PATCH net-next 2/5] openvswitch: return NF_ACCEPT when OVS_CT_NAT is net set in info nat References: <8c17d8ea9547254180031510a3160fcd97ac945f.1668527318.git.lucien.xin@gmail.com> Date: Wed, 16 Nov 2022 15:56:03 -0500 In-Reply-To: <8c17d8ea9547254180031510a3160fcd97ac945f.1668527318.git.lucien.xin@gmail.com> (Xin Long's message of "Tue, 15 Nov 2022 10:50:54 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Xin Long writes: > Either OVS_CT_SRC_NAT or OVS_CT_DST_NAT is set, OVS_CT_NAT must be > set in info->nat. Thus, if OVS_CT_NAT is not set in info->nat, it > will definitely not do NAT but returns NF_ACCEPT in ovs_ct_nat(). > > This patch changes nothing funcational but only makes this return > earlier in ovs_ct_nat() to keep consistent with TC's processing > in tcf_ct_act_nat(). > > Signed-off-by: Xin Long > --- Acked-by: Aaron Conole